Closed Bug 1146194 Opened 6 years ago Closed 4 years ago
Multiple cookies with the same name not shown
58 bytes, text/x-review-board-request
The list of cookies appears to show only one cookie for each name, ignoring differences in path, domain, etc., thus a developer could think they only have one cookie when they might have several.
We need to have our table widget work with compound keys to fix this.
It goes without saying that this column should be hidden and lets name the column "uniqueKey." Ideally this would be hidden from the user but I don't think it needs to be.
If we are enabling the storage panel by default we should fix this. We don't really need the md5 hash, the key can be name.host.path.
Assignee: nobody → mratcliffe
This is taking longer than I would have expected and there appear to be some issues setting cookies in Firefox that have the same name over different paths... especially when running local pages. Attaching my WIP patch and going back to working on browser.html.
Assignee: mratcliffe → nobody
Duplicate of this bug: 1292336
Priority: -- → P2
Assignee: nobody → mratcliffe
Attachment #8775115 - Attachment is obsolete: true
Attachment #8809871 - Flags: review?(gl) → review+
Multiple test failures due to the compound primary keys.
Attachment #8809871 - Flags: review+
Comment on attachment 8809871 [details] Bug 1146194 - Multiple cookies with the same name not shown More failing tests.
Change summary: 1. Fixed the original issue and allow cookies of the same name and different compound keys to be displayed. 2. Added a private uniqueKey column and made it possible for other storage types to do the same. 3. Fixed a bug with bookmarks. Bookmarks are row placeholders needed for when an items key is changed. Now that a key can consist of compound keys we need to update the bookmark more often. 4. Split browser_storage_dynamic_updates.js into 3 files: - browser_storage_dynamic_updates_cookies.js - browser_storage_dynamic_updates_localStorage.js - browser_storage_dynamic_updates_sessionStorage.js 5. Fixed many eslint issues in the files that I edited. 6. Changed tests to work with cookies, which now have compound keys. 7. For server-side tests we were not clearing cookies between tests. Some tests appear to have been written to expect the incorrect input. We now clear cookies between tests and work with the correct data. 8. localStorage was not cleared at the end of some tests potentially causing issues. 9. The order of the first three columns in the cookie table have been changed from name, path, domain to name, domain, path to be consistent with the order of fields in the compound key. 10. When querying cells in tests we now include data in hidden columns as this ultimately simplifies tests. 11. Improved error reporting in tests to show available keys when a row can't be found. This makes debugging tests much easier. 12. Changed numeric values in getFields() metheds to Boolean instead of 1 and 0 for readability.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/34fce7c12173 Multiple cookies with the same name not shown r=gl
No longer blocks: 1312444
You need to log in before you can comment on or make changes to this bug.