1146220 - [NFC] BT did not back to the default setting after sender which initial BT disabled try to send files to receiver which is receiving files

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alison Shiue]

Gaia-Rev        44c62060581fde8de1e12e94cf55e9673b401a47
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e6140a32902a
Build-ID        20150322162502
Version         37.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150322.200808
FW-Date         Sun Mar 22 20:08:19 EDT 2015
Bootloader      L1TC100118D0


STR:
1. Enable NFC on both phone
2. Enable BT only on device A
3. Device B try to share a file when device A is receiving files from others 
4. Device B show "Cannot send file right now...."
5. Check BT status on device B

Expected result:
BT disabled

Actual result:
BT enabled

Comment 1

[Alison Shiue]

Hi Arno,
Could you please check this issue? Thank you.

Comment 2

[arno]

(In reply to Alison Shiue from comment #1)
> Hi Arno,
> Could you please check this issue? Thank you.

Alison: you are right, as always! The fix should be a one-liner, however, I am traveling and cannot test on a device right now. I will be back at the office on Friday when I can test and request review. If Wesley thinks this is wasting too much time, I would like to ask Yoshi to prepare a build for you so you can test:
https://github.com/svic/gaia/tree/Bug_1146220

Note that this also needs to be fixed in master.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: i'm pretty sure this is regression

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] svic:Bug_1146220_v2.2 > mozilla-b2g:v2.2

Comment 5

[arno]

Attachment: Turn off BT at sender when denying concurrent file transfers (v2.2)

Forgot to turn off BT after failed transfer. Changed unit test accordingly.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] svic:Bug_1146220 > mozilla-b2g:master

Comment 7

[arno]

Attachment: Turn off BT at sender when denying concurrent file transfers (master)

Patch for master

Comment 8

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8584897 [details] [review]
Turn off BT at sender when denying concurrent file transfers (master)

LGTM

Comment 9

[arno]

Comment on attachment 8584865 [details] [review]
Turn off BT at sender when denying concurrent file transfers (v2.2)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Undesirable UX since BT won't be turned off
[Testing completed]: added unit test case
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 10

[bhavana bajaj [:bajaj]]

waiting for master landing before uplifting on the branch.

Comment 11

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 12

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 13

[bhavana bajaj [:bajaj]]

alive/arno, Ni as this needs to land on master.

Comment 14

[arno]

Alive r+ed both patches and Vincent set the CI flag. I don't understand the autolander's comments 11 and 12. I'll set the CI flags again for both patches.

Comment 15

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 16

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 17

[arno]

Vincent, Wesley: what needs to be done here? Autolander keeps on rejecting the CI flag.

Comment 18

[[:fabrice] Fabrice Desré]

Kevin, looks like we need to update the reviewer list or force something there.

Comment 19

[Kevin Grandon :kgrandon]

(In reply to Fabrice Desré [:fabrice] from comment #18)
> Kevin, looks like we need to update the reviewer list or force something
> there.

If this is truly NFC code, then it should be done by a suggested reviewer, which I think are correct? If it's a sub-component of the system app, then it should be moved, or we should create a new component.

For now, it looks like the code is in the system app, so changing the component should be a quick fix for this bug.

Comment 20

[GitHub Autolander Bot]

Pull request has landed in v2.2: https://github.com/mozilla-b2g/gaia/commit/41a4e59d6670de93385d67d9fd61f6fa77c3c478

Comment 21

[Kevin Grandon :kgrandon]

(In reply to Autolander from comment #20)
> Pull request has landed in v2.2:
> https://github.com/mozilla-b2g/gaia/commit/
> 41a4e59d6670de93385d67d9fd61f6fa77c3c478

Oh, I didn't see that there was another PR for 2.2 here. We're fixing this workflow problem in bug 1150080.

Reverted for now until we get approval: https://github.com/mozilla-b2g/gaia/commit/485322797a069e5b185931e87d15d4e921e25b64

Comment 22

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d34e31859e0348503c00ea7615904c0594abc3c1

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/a37757c74c103c40d4374e0bcf8796390d6fad74

Comment 24

[Alison Shiue]

Verified on:
[2.2]
Build ID               20150412162502
Gaia Revision          cec00d643f517ffd96cde559cd3bbd43ab85816c
Gaia Date              2015-04-10 21:41:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5005522fd68e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150412.200029
Firmware Date          Sun Apr 12 20:00:40 EDT 2015
Bootloader             L1TC000118D0

[3.0]
Build ID               20150412160203
Gaia Revision          3c68964cb9fdba7cf0f6829b7f44562acaf1f1d7
Gaia Date              2015-04-10 14:38:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0a46652bd992
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150412.192808
Firmware Date          Sun Apr 12 19:28:21 EDT 2015
Bootloader             L1TC100118D0