Remove fromTab and toTab properties from "select" events in tabbrowser.xml and tabbox.xml

RESOLVED FIXED in Firefox 39

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: John Kang, Mentored)

Tracking

Trunk
Firefox 39
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Bug 1135045 set fromTab and toTab properties on "select" events in browser/base/content/tabbrowser.xml and toolkit/content/widgets/tabbox.xml. Then bug 1144782 made us use the "TabSelect" event rather than the "select" event, leaving fromTab and toTab completely unused. So we should remove them.

The relevant code can be found here:

http://hg.mozilla.org/mozilla-central/annotate/e730012260a4/browser/base/content/tabbrowser.xml#l5523

http://hg.mozilla.org/mozilla-central/annotate/e730012260a4/toolkit/content/widgets/tabbox.xml#l667
(Assignee)

Comment 1

3 years ago
Did you want every instance of fromTab and toTab, including the enclosing if-else statements removed?
(Reporter)

Comment 2

3 years ago
We should just stop setting event.fromTab and event.toTab in the code I pointed to. I'm not sure what if-else statements you mean.
(Assignee)

Comment 5

3 years ago
Created attachment 8582710 [details] [diff] [review]
bug1146252.diff

Here you go! Please let me know if anything else is required or if I made a mistake. :)
(Reporter)

Comment 6

3 years ago
Comment on attachment 8582710 [details] [diff] [review]
bug1146252.diff

Looks good. Thanks!
Attachment #8582710 - Flags: review+
(Reporter)

Updated

3 years ago
Assignee: nobody → johnkang.h
Keywords: checkin-needed
(Assignee)

Comment 7

3 years ago
Great. Could I bother you again for a vouch?
https://mozillians.org/en-US/u/jkang8/
(Reporter)

Comment 8

3 years ago
(In reply to John Kang from comment #7)
> Great. Could I bother you again for a vouch?
> https://mozillians.org/en-US/u/jkang8/

done!
https://hg.mozilla.org/mozilla-central/rev/a83feceee78b
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
(Assignee)

Comment 11

3 years ago
Hi, I'm still learning about contributing to Firefox. Is my patch already checked into the repository or do I need to still do it? Also, how do I have my contributions show up on my GitHub account?

Thanks.
(Reporter)

Comment 12

3 years ago
(In reply to John Kang from comment #11)
> Hi, I'm still learning about contributing to Firefox. Is my patch already
> checked into the repository or do I need to still do it?

It has been checked in (comment 9) and merged to mozilla-central (comment 10).

> Also, how do I have my contributions show up on my GitHub account?

Sorry, I have no idea about that. Our primary repository is https://hg.mozilla.org/mozilla-central/. I think there's a mirror on GitHub, but it's read-only. I'm not sure whether that's relevant to your question.
(In reply to Dão Gottwald [:dao] from comment #12)
> (In reply to John Kang from comment #11)
> > Also, how do I have my contributions show up on my GitHub account?
> 
> Sorry, I have no idea about that. Our primary repository is
> https://hg.mozilla.org/mozilla-central/. I think there's a mirror on GitHub,
> but it's read-only. I'm not sure whether that's relevant to your question.

Yes, as soon as that mirror is synced it'll show up as a contribution to mozilla/gecko-dev. In fact, I can already see it listed on your GitHub profile page :)
You need to log in before you can comment on or make changes to this bug.