1146299 - (bookmark keywords are broken!) v27 migration is using a bookmark description instead of POST data

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]:

Looks like the migration query is using the wrong item annotations when migrating postData, thus using for example page description instead of POST data.

This is pretty bad, we need a new migration step to fix it.

Comment 1

[Marco Bonardo [:mak]]

Attachment: patch v1

Luckily, I kept around the data to rebuild keywords.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8582074 [details] [diff] [review]
patch v1

Review of attachment 8582074 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/191f0b9b6a65

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Marco, when did this break? Do we need to test or uplift this?  Thanks!

Comment 5

[Marco Bonardo [:mak]]

No, this was Nightly only, luckily.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/191f0b9b6a65

Comment 7

[Jan Moesen]

Is this the reason for the following? When I entered the keyword for a bookmarklet ("javascript:…"), it would only show the "javascript:" URL without executing it. I had to press Enter again to actually execute the code.

I deleted the bookmarklets, re-imported a backup of my bookmarks.html, and then the keywords started working again.

If this is an unreleated issue, I'll file a new bug.

Comment 8

[Marco Bonardo [:mak]]

(In reply to Jan Moesen from comment #7)
> Is this the reason for the following? When I entered the keyword for a
> bookmarklet ("javascript:…"), it would only show the "javascript:" URL
> without executing it. I had to press Enter again to actually execute the
> code.

it's due to this bug, yes.