Closed
Bug 1146366
Opened 10 years ago
Closed 10 years ago
Bookmark star is not updating when switching tabs
Categories
(Firefox for iOS :: Browser, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fennec | + | --- |
People
(Reporter: mfinkle, Assigned: wesj)
Details
Attachments
(1 file)
STR
1. Open a few tabs
2. Bookmark a tab
3. Switch to a tab that is not bookmarked
The "star" is still filled.
|
Reporter | |
Updated•10 years ago
|
tracking-fennec: --- → +
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → wjohnston
|
|
Assignee | |
Comment 1•10 years ago
|
||
Going to look into a kif test for this now...
Attachment #8582042 -
Flags: review?(bnicholson)
|
||
Updated•10 years ago
|
Attachment #8582042 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8582042 [details] [review]
Pull request
I added a second commit here with a KIF test for this (and this button in general since we have no tests for it). Mind looking it over brian?
Attachment #8582042 -
Flags: review+ → review?(bnicholson)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8582042 [details] [review]
Pull request
r=me, but I think there are a few things that need to be fixed. In particular, I think some of the accessibilityLabel changes should be reverted.
Attachment #8582042 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•