Closed Bug 114640 Opened 23 years ago Closed 23 years ago

No message after "Apply Theme"

Categories

(SeaMonkey :: Preferences, defect, P1)

Product:
SeaMonkey
Component:
Preferences
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.7

People

(Reporter: askwar, Assigned: samir_bugzilla)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Use getFormattedString.
1.08 KB, patch
morse
: review+
samir_bugzilla
: superreview+
Details | Diff | Splinter Review 
Using build 2001121106 on Linux.

After I click on "Apply Theme" in the themes section, no message is shown.  It
used to be, that there was a message telling the user to restart Mozilla for the
changes to have effect.  That doesn't happen with this ubild.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: regression
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
morse, please r.
blake, please sr.
Keywords: mozilla0.9.7, nsbeta1, patch, review
<stringbundle> has a getFormattedString wrapper, please use that instead.  
sr=blake if you do.

    
  

        Attachment #61367 -
        Attachment is obsolete: true

    
  

        Attachment #61371 -
        Flags: superreview+

    
    

    
  
Comment on attachment 61371 [details] [diff] [review]
Use getFormattedString.

r=morse

        Attachment #61371 -
        Flags: review+

    
    

    
  
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
getFormattedString() only takes two arguments; it calculates the third, the 
array length, internally (which is one of its conveniences).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
OK, fixed it and checked it in.
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
this is more or less moot, since Apply Theme has been removed from the Themes
preferences panel. moreover, dynamic theme switching is on now.

rs vrfy.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: