1146426 - Add support for funsize in desktop_l10n.py

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Massimo Gervasini [:massimo]]

Our desktop_l10n.py script should expose the following properties to funsize:
* platform
* branch
* appName
* list of locales

Comment 1

[Rail Aliiev [:rail]]

I looked at http://dev-master2.bb.releng.use1.mozilla.com:8914/builders/WINNT%206.1%20x86-64%20ash%20nightly%20l10n%201%2F5/builds/13

This what we have there now:

branch: WINNT 6.1 x86-64 ash (sounds wrong)
locales: {"en-GB": "Success", "eo": "Success", "ast": "Success", "es-AR": "Success", "de": "Success", "es-CL": "Success", "ar": "Success", "cs": "Success"} (this is good, enough for funsize)
product: firefox (need appName: aka Firefox)
platform: win64 (this is good, enough for funsize)


As a summary:

1) fix branch
2) set appName property

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: [mozharness] Bug 1146426 - add support for funsize in mozharness repacks.patch

Comment 3

[Massimo Gervasini [:massimo]]

Comment on attachment 8583836 [details] [diff] [review]
[mozharness] Bug 1146426 - add support for funsize in mozharness repacks.patch

Thanks Rail!

https://hg.mozilla.org/build/mozharness/rev/2ec79d0bea5f

Comment 4

[Rail Aliiev [:rail]]

Anything else here?

Comment 5

[Massimo Gervasini [:massimo]]

It's in production and it generates:

...
06:24:28     INFO - #####
06:24:28     INFO - ##### Running funsize-props step.
06:24:28     INFO - #####
06:24:28     INFO - Running main action method: funsize_props
06:24:28     INFO - funsize info: {'platform': 'linux', 'branch': 'mozilla-central', 'locales': ['ar', 'ast', 'cs', 'de', 'en-GB', 'eo', 'es-AR', 'es-CL', 'es-ES', 'es-MX', 'fa', 'fr', 'fy-NL', 'gl'], 'appName': 'Firefox'}
06:24:28     INFO - Setting buildbot property funsize_info to {'platform': 'linux', 'branch': 'mozilla-central', 'locales': ['ar', 'ast', 'cs', 'de', 'en-GB', 'eo', 'es-AR', 'es-CL', 'es-ES', 'es-MX', 'fa', 'fr', 'fy-NL', 'gl'], 'appName': 'Firefox'}
06:24:28     INFO - mkdir: /builds/slave/m-cen-lx-l10n-ntly-1-000000000/properties
06:24:28     INFO - Writing buildbot properties ['funsize_info'] to /builds/slave/m-cen-lx-l10n-ntly-1-000000000/properties/funsize_info
06:24:28     INFO - Writing to file /builds/slave/m-cen-lx-l10n-ntly-1-000000000/properties/funsize_info
06:24:28     INFO - Contents:
06:24:28     INFO -  funsize_info:{'platform': 'linux', 'branch': 'mozilla-central', 'locales': ['ar', 'ast', 'cs', 'de', 'en-GB', 'eo', 'es-AR', 'es-CL', 'es-ES', 'es-MX', 'fa', 'fr', 'fy-NL', 'gl'], 'appName': 'Firefox'}
...

So I think there's nothing else to do :)

Comment 6

[Rail Aliiev [:rail]]

\o/

Comment 7

[Rail Aliiev [:rail]]

Attachment: json.dumps.diff

Need to json.dumps() as in https://hg.mozilla.org/build/mozharness/file/2ec79d0bea5f/scripts/desktop_l10n.py#l509 to make it JSON compatible (double quotes instead of single quotes).

Comment 8

[Massimo Gervasini [:massimo]]

Comment on attachment 8594335 [details] [diff] [review]
json.dumps.diff

Thanks rail!

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8594335 [details] [diff] [review]
json.dumps.diff

https://hg.mozilla.org/build/mozharness/rev/b693ae365bfa

Comment 10

[Rail Aliiev [:rail]]

mgerva, can you take care of landing this? I'm not sure what is required here, merge to production only or pinning as well.

Comment 11

[Massimo Gervasini [:massimo]]

(In reply to Rail Aliiev [:rail] from comment #10)
> mgerva, can you take care of landing this? I'm not sure what is required
> here, merge to production only or pinning as well.

mozharness repacks use the tip of production branch. I am running a reconfig in few minutes.

Comment 12

[Release Engineering SlaveAPI Service]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 13

[Massimo Gervasini [:massimo]]

Rail, is it fixed now?

Comment 14

[Rail Aliiev [:rail]]

LGTM!