1146555 - [e10s] browser_ssl_error_reports.js causes unsafe CPOW usage warnings

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Ian Moody [:Kwan] (UTC+0)]

+++ This bug was initially created as a clone of Bug #1133577 +++

Mined from test logs

In browser/base/content/test/general/browser_ssl_error_reports.js:

      onStateChange: function(aWebProgress, aRequest, aStateFlags, aStatus) {
        let doc = aBrowser.contentDocument;

        if (doc && doc.getElementById("reportCertificateError")) { <- Causes CPOW warning
          // Wait until the documentURI changes (from about:blank) this should
          // be the error page URI.
          let documentURI = doc.documentURI; <- Causes CPOW warning
          if (documentURI == originalDocumentURI) {
            return;
          }

[...]

let testSendReportManual = function*(testURL, suffix) {
  setup();
  Services.prefs.setBoolPref("security.ssl.errorReporting.enabled", true);
  Services.prefs.setCharPref("security.ssl.errorReporting.url",
    "https://example.com/browser/browser/base/content/test/general/pinning_reports.sjs?" + suffix);

  let tab = gBrowser.addTab(testURL, {skipAnimation: true});
  let browser = tab.linkedBrowser;
  let mm = browser.messageManager;
  mm.loadFrameScript(ROOT + "browser_ssl_error_reports_content.js", true);

  gBrowser.selectedTab = tab;

  // ensure we have the correct error message from about:neterror
  let netError = createNetworkErrorMessagePromise(browser);
  yield netError;
  netError.then(function(val){
    is(val.startsWith("An error occurred during a connection to"), true,
                      "ensure the correct error message came from about:neterror");
  });

  let btn = browser.contentDocument.getElementById("reportCertificateError"); <- Causes CPOW warning
  let deferredReportSucceeds = Promise.defer();

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This is test only.

Comment 2

[:Gijs (he/him)]

This looks done to me.