1146632 - [e10s] sdk/test/assert.js causes unsafe CPOW usage warnings

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P4)

Description

[Ian Moody [:Kwan] (UTC+1)]

Mined from test logs

In addon-sdk/source/lib/sdk/test/assert.js:

  fail: function fail(e) {
    if (!e || typeof(e) !== 'object') {
      this._log.fail(e);
      return;
    }
    let message = e.message; <- Causes CPOW warning
    try {
      if ('operator' in e) { <- Causes CPOW warning
        message += [
          " -",
          source(e.actual),
          e.operator,
          source(e.expected)
        ].join(" ");
      }
    }
    catch(e) {}
    this._log.fail(message);
  },

[...]

  /**
   * The equality assertion tests shallow, coercive equality with `==`.
   * @example
   *    assert.equal(1, 1, "one is one");
   */
  equal: function equal(actual, expected, message) {
    if (actual == expected) { <- Causes CPOW warning
      this.pass(message);
      return true;
    }

    this.fail({
      actual: actual,
      expected: expected,
      message: message,
      operator: "=="
    });
    return false;
  },

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This module is for use in tests, so I think we can consider this test only.

Comment 2

[:shell escalante]

we are going to check which tests pass - and then disable all that do not to detect breakages from this point on.  correcting the test suite issue across the board is a months long effort - that doesn't align with 2017 plans.

Comment 3

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562