1146677 - If user turns off mixed content blocking, they will get the grey triangle instead of the yellow one

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Tanvi Vyas[:tanvi]]

I don't remember what my reasoning was for this:
https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#6837

If the state is broken and...
* mixed active content is loaded -> show the yellow triangle
* only mixed display content is loaded -> show the grey triangle
* mixed active content is loaded BUT the user has turned off mixed content blocking -> show the grey triangle.

In the third case, we should show the yellow triangle regardless of what preferences the user has chosen.  Hence, we should stop checking the pref value in the if clauses.

Comment 1

[Tanvi Vyas[:tanvi]]

Note that mobile does this too, but perhaps for another reason?  It could be that it was reproducing desktops behavior, or maybe their is another reason that we have to check the pref before showing the different icon in mobile:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#6880

Comment 2

[Tanvi Vyas[:tanvi]]

Attachment: Mixed Content pref shouldn't affect site identity messages and icons

Comment 3

[Tanvi Vyas[:tanvi]]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a19854d1fc7

Comment 4

[Justin Dolske [:Dolske]]

(In reply to Tanvi Vyas [:tanvi] from comment #0)
> I don't remember what my reasoning was for this

You added this in bug 838359. And I think my bug 838359 comment 12 now applies. :-)

IE, we added this originally because we didn't yet block mixed-content by default or have the shield UI. And so we didn't want our users to just suddenly start getting a bright yellow warning as the first step to blocked mixed content.

Now we block by default with sensible UI, so it's reasonable that someone who turns that _off_ should see more visible UI.

Comment 5

[Tanvi Vyas[:tanvi]]

Thanks Justin for reminding me of the context behind this bug!

Pushed to inbound:  https://hg.mozilla.org/integration/mozilla-inbound/rev/b709f9a5a594

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b709f9a5a594