Closed
Bug 1146735
Opened 9 years ago
Closed 9 years ago
Change outer container in @layout/anchored_popup to FrameLayout
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: mcomella, Assigned: inouju, Mentored)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 1 obsolete file)
1.66 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
Lucas once told me FrameLayout is more performant than LinearLayout because it does away with a lot of measuring code in layout - the anchored popup outermost container, used to draw the shadow background, uses LinearLayout [1] even though it has one child (and will forever have one child, as far as I can tell). It should be changed to a FrameLayout. Chenxia, mentorable? [1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/anchored_popup.xml?rev=534e729ad1d7#6
Flags: needinfo?(liuche)
Updated•9 years ago
|
Mentor: liuche
Flags: needinfo?(liuche)
Whiteboard: [good first bug]
Comment 1•9 years ago
|
||
hello again its me i want to work on this bug. wait ill submit my patch
Comment 2•9 years ago
|
||
Go ahead. If you have any questions, please use the needinfo box pointing to your mentor.
Comment 3•9 years ago
|
||
ok this bug is in firefox for android.I want the screen shot if possible what exactly happening.
Flags: needinfo?(liuche)
Comment 4•9 years ago
|
||
Hi Amit, do you have a working build of Firefox for Android? If not, you can get started here: https://wiki.mozilla.org/Mobile/Fennec/Android#Preparing_your_build_environment After that, you can make a patch and make sure it follows the patch guidelines. Basically, this bug is for replacing the LinearLayout with a FrameLayout at this point: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/layout/anchored_popup.xml?rev=534e729ad1d7#6 Afterwards, the image should look the same as before, but should be more performant. You can upload screenshots of before/after, to make sure they haven't changed.
Flags: needinfo?(liuche)
Assignee | ||
Comment 5•9 years ago
|
||
I'm not quite sure if I did the patch attachment correctly, but I talked to Chenxia on irc and said I could take this bug.
Attachment #8650759 -
Flags: review?(liuche)
Comment 6•9 years ago
|
||
Comment on attachment 8650759 [details] [diff] [review] anchored_popup change to FrameLayout Hi Justin, this patch is in fact not in the right format :) but you can take a look here and see how you should make it. https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F Clearing the review flag for now.
Attachment #8650759 -
Flags: review?(liuche)
Assignee | ||
Comment 7•9 years ago
|
||
Sorry! I think this should be right now, but let me know if anything is missing.
Attachment #8650759 -
Attachment is obsolete: true
Attachment #8651066 -
Flags: review?(liuche)
Comment 8•9 years ago
|
||
Comment on attachment 8651066 [details] [diff] [review] bug-1146735-fix Review of attachment 8651066 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8651066 -
Flags: review?(liuche) → review+
Updated•9 years ago
|
Assignee: nobody → inouju
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bf111f5f87d7
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•