1146834 - Uint8Array.slice does not exist in Fx37 so context decryption will fail

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

Proposed fix:

```js
if (!Uint8Array.prototype.slice)
  Uint8Array.prototype.slice = Uint8Array.prototype.subarray;
```

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Am I understanding the impact correctly here - this only affects link clickers who will be using Firefox 37 when clicking links from people who generated them in Firefox 39?

Comment 2

[Mike de Boer [:mikedeboer]]

Yes. (which is quite likely when this feature is riding the trains and not in release yet)

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: use Uint8Array's subarray when slice is not available in Loop content pages

You can validate this patch by loading the Shared marionette tests (http://localhost:3000/test/shared) in Firefox 37 or lower and see them fail without the patch applied, but succeed with the patch applied.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8586697 [details] [diff] [review]
Patch v1: use Uint8Array's subarray when slice is not available in Loop content pages

Review of attachment 8586697 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/content/shared/js/utils.js
@@ +170,5 @@
>  
> +  // We can alias `subarray` to `slice` when the latter is not available, because
> +  // they're semantically identical.
> +  if (!Uint8Array.prototype.slice)
> +    Uint8Array.prototype.slice = Uint8Array.prototype.subarray;

nit: please enclose this in braces.

Comment 5

[Mike de Boer [:mikedeboer]]

Pushed to fx-team with comment addressed: https://hg.mozilla.org/integration/fx-team/rev/72be1e6e2f31

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72be1e6e2f31