Closed Bug 1146840 Opened 9 years ago Closed 9 years ago

Reload button needs a proper localized AccessibilityLabel property

Categories

(Firefox for iOS :: Browser, defect)

ARM
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
fennec + ---

People

(Reporter: MarcoZ, Assigned: tmchugh98)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

47 bytes, text/x-github-pull-request
bnicholson
: review+
Details | Review
The Reload button to the right of the URL bar needs a proper AccessibilityLabel so it can be localized. Right now, VoiceOver reads something like "Toolbar Reload", which sounds more like the name of an image used for this button than an actual button label. The AccessibilityLabel property of the button should be set to an NSLOcalizedString that contains the proper spoken label like "Reload" or "Reload page".
tracking-fennec: --- → ?
tracking-fennec: ? → +
Attached file Pull request
Thanks for the pull request! I added a few comments.
Attachment #8586434 - Flags: feedback+
Assignee: nobody → tmchugh98
Status: NEW → ASSIGNED
Just updated pull request with commits from comments.
Merged. Thanks again for the contribution!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8586434 - Flags: feedback+ → review+
Blocks: iosa11y
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: