1146895 - ASan JS shells broken due to jemalloc switch

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The JS shell no longer builds since we switched to jemalloc for JS. The reason is that we now include mozglue, which contains a definition for __asan_default_options which we also have in js/src/asmjs/AsmJSSignalHandlers.cpp for the JS shell. The error is:

../../../build/unix/gold/ld: error: ../libjs_static.a(Unified_cpp_js_src0.o): multiple definition of '__asan_default_options'
../../../build/unix/gold/ld: js/src/shell/../../../mozglue/build/AsanOptions.o: previous definition here
../../../build/unix/gold/ld: warning: Cannot export local symbol '__sanitizer_pthread_attr_getstack'
../../../build/unix/gold/ld: warning: Cannot export local symbol '__asan_default_options'
clang-3.5: error: linker command failed with exit code 1 (use -v to see invocation)

The solution is simple, we rip out the definition in js/src/asmjs/AsmJSSignalHandlers.cpp in favour of the mozglue definition. With that change, we also have now only one central place where ASan default options are defined. Patching coming.

Comment 1

[Christian Holler (:decoder)]

Attachment: bug1146895.patch

This patch removes the (now) redundant definition of __asan_default_options. With this patch and --disable-jemalloc (which is required due to ASan itself) I get a success build. The build also passes the ASM.js jit-tests, so the default options are actually working (otherwise, ASan would start catching ASM.js segmentation fault signals like in bug 857189).

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8582415 [details] [diff] [review]
bug1146895.patch

Review of attachment 8582415 [details] [diff] [review]:
-----------------------------------------------------------------

My favorite kind of patch!

Comment 3

[Christian Holler (:decoder)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d02be94c97e8

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d02be94c97e8