Closed Bug 1146912 Opened 5 years ago Closed 5 years ago

Finish replacing TextureHost::GetTextureSources by TextureHost::BindTextureSource

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: nical, Assigned: nical)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file, 1 obsolete file)

We already did the move to BindTextureSource where it matters for performance. Now let's move the other classes so that we can remove GetTextureSource entirely since having both is confusing and risky (GetTextureSources will just not work with gralloc textures, for example).
Attached patch patch (obsolete) — Splinter Review
Attachment #8582406 - Flags: review?(sotaro.ikeda.g)
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [gfx-noted]
Comment on attachment 8582406 [details] [diff] [review]
patch

Review of attachment 8582406 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/d3d11/TextureD3D11.h
@@ +243,5 @@
>  public:
>    DXGITextureHostD3D11(TextureFlags aFlags,
>                         const SurfaceDescriptorD3D10& aDescriptor);
>  
> +  virtual TextureSource* BindTextureSource(CompositableTextureSourceRef& aTexture) override;

Should't this be bool type?

::: gfx/layers/d3d9/TextureD3D9.h
@@ +297,5 @@
>  public:
>    TextureHostD3D9(TextureFlags aFlags,
>                    const SurfaceDescriptorD3D9& aDescriptor);
>  
> +  virtual TextureSource* BindTextureSource(CompositableTextureSourceRef& aTexture) override;

Should't this be bool tyep?

@@ +338,5 @@
>  public:
>    DXGITextureHostD3D9(TextureFlags aFlags,
>      const SurfaceDescriptorD3D10& aDescriptor);
>  
> +  virtual TextureSource* BindTextureSource(CompositableTextureSourceRef& aTexture) override;

Shouldn't this be bool type?
Flags: needinfo?(nical.bugzilla)
(In reply to Sotaro Ikeda [:sotaro] from comment #2)
> 
> Shouldn't this be bool type?

Yeah, The patch is running on try at the moment to catch the mistakes I made on files that are not built on linux, hopefully there aren't too many of them.
Flags: needinfo?(nical.bugzilla)
Attached patch v2Splinter Review
Fixes build failures on windows and mac.
Attachment #8582406 - Attachment is obsolete: true
Attachment #8582406 - Flags: review?(sotaro.ikeda.g)
Attachment #8583160 - Flags: review?(sotaro.ikeda.g)
Comment on attachment 8583160 [details] [diff] [review]
v2

Review of attachment 8583160 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8583160 - Flags: review?(sotaro.ikeda.g) → review+
https://hg.mozilla.org/mozilla-central/rev/a626cde31115
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.