Closed Bug 1147029 Opened 6 years ago Closed 6 years ago

Land luciddream in-tree

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: jgriffin, Assigned: jgriffin)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

Land luciddream in-tree,
20.01 KB, patch
ted
: review+
Details | Diff | Splinter Review
Use in-tree luciddream instead of cloning,
6.74 KB, patch
armenzg
: review+
Details | Diff | Splinter Review
Bump mozharness to 87da3e48572d,
646 bytes, patch
jlund
: review+
Details | Diff | Splinter Review 
We should move the luciddream harness in-tree.
Here's a try run to demonstrate the tests.zip piece works ok: https://treeherder.mozilla.org/#/jobs?repo=try&revision=431bb34afefa
Attachment #8582755 - Flags: review?(ted)
Comment on attachment 8582755 [details] [diff] [review]
Land luciddream in-tree,

Review of attachment 8582755 [details] [diff] [review]:
-----------------------------------------------------------------

I had mused about renaming luciddream to something more vanilla when doing this, but I don't really care that much. Thanks for doing this!
Attachment #8582755 - Flags: review?(ted) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/14be412b39b5

Will use the same bug to tackle the related mozharness changes.
Keywords: leave-open
Target Milestone: --- → mozilla39
Attachment #8584701 - Flags: review?(armenzg)
Updated to strip some now-obsolete options
Attachment #8584708 - Flags: review?(armenzg)
Attachment #8584701 - Attachment is obsolete: true
Attachment #8584701 - Flags: review?(armenzg)
Attachment #8584708 - Flags: review?(armenzg) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #6)
> Created attachment 8584708 [details] [diff] [review]
> Use in-tree luciddream instead of cloning,
> 
> Updated to strip some now-obsolete options

https://hg.mozilla.org/build/mozharness/rev/9965bd9440cd
I pushed to try and it still pull luciddream from github:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=11c076c136c4
Is there something to do to use the in-tree version? Or do I need to push with a newer mozilla-central?
I still need to update the mozharness pointer on trunk; I'll do that today.
Attachment #8586179 - Flags: review?(jlund)
Comment on attachment 8586179 [details] [diff] [review]
Bump mozharness to 87da3e48572d,

Review of attachment 8586179 [details] [diff] [review]:
-----------------------------------------------------------------

apologies for delay. I tend to leave reviews to build for a day but I shouldn't block on patches like these. feel free to ask for a quick stamp over irc if you like.
Attachment #8586179 - Flags: review?(jlund) → review+
https://hg.mozilla.org/mozilla-central/rev/a16754973862
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: mozilla39 → mozilla40
You need to log in before you can comment on or make changes to this bug.