1147106 - Hook CDM update check with Add-ons Manager’s "Check for updates" menu item

Status: RESOLVED WORKSFORME

(Firefox :: General, defect, P1)

Description

[Chris Peterson [:cpeterson]]

The user should be able to force an update check or download. The Add-ons Manager already provides UI to do this with the "Check for updates" menu item.

Comment 1

[Stephen A Pohl [:spohl]]

Unless we're talking about two different menu items, doesn't this "Check for updates" open a separate tab with a list of all the plugins and links to update them if they're out of date? The UX here seems weird for updating GMPs, which are usually handled/updated in the background without user interaction.

We do implement findUpdates() in the GMPProvider, which is exposed via right-clicking the GMP in the addons manager. We may want to expose this more prominently instead?

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Stephen Pohl [:spohl] from comment #1)
> Unless we're talking about two different menu items, doesn't this "Check for
> updates" open a separate tab with a list of all the plugins and links to
> update them if they're out of date? The UX here seems weird for updating
> GMPs, which are usually handled/updated in the background without user
> interaction.

No, that is the Plugin Check website linked from the Add-ons Manager's "Check to see if your plugins are up to date" link on the Plugins tab. "Check for Updates" is a menu item hidden away in the "gear" button in the top-right corner of the Add-ons Manager.


> We do implement findUpdates() in the GMPProvider, which is exposed via
> right-clicking the GMP in the addons manager. We may want to expose this
> more prominently instead?

Oh. I see the "Find Updates" in the right-click context menu now. We could leave this context menu item, but it might make more sense to remove this context menu item and integrate this GMP update check with the Add-ons Manager's general "Check for Updates" check.

Comment 3

[Stephen A Pohl [:spohl]]

Ah, I see the menu item now! I didn't get a chance to look into this yet, but if this simply calls findUpdates() on every addon, we might be covered already.

Comment 4

[Chris Peterson [:cpeterson]]

Stephen: is this work done? Does the Add-ons Manager's "Check for Updates" menu item already call findUpdates()?

Comment 5

[Stephen A Pohl [:spohl]]

Yes, as best as I can tell, we run findUpdates() on each addon from the "Check for Updates" menu item [1].

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.js#983

Comment 6

[Chris Peterson [:cpeterson]]

Thanks. I'm closing this bug WFM for now.