1147107 - Update mozilla-download to fetch builds from taskcluster index instead of ftp

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Comment 1

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Pull request

Review request for 1.0.0-alpha (doesn't currently do things like windows or mac or downloading non-firefox products)

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8585737 [details] [review]
Pull request

>https://github.com/mozilla-b2g/mozilla-download/pull/16

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Pull request

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8585738 [details] [review]
Pull request

Bikeshed with us!

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

landed gaia-node-modules part https://github.com/mozilla-b2g/gaia-node-modules/commit/6153f76e09f1fd218b1bafee99cad0aac972e993 carrying over jlal review from mozilla-download

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] gaye:mozilla-download-v1.0.0 > mozilla-b2g:master

Comment 8

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/30462283ce20a2481b9f6bd918218d65943548ec mozilla-download changes downstreamed to gaia master

Comment 9

[Julien Wajsberg [:julienw]]

Could you also change the scripts in [1] and [2] ?

[1] https://github.com/mozilla-b2g/gaia/blob/master/tests/ci/unit-tests-in-firefox/install
[2] https://github.com/mozilla-b2g/gaia/blob/master/tests/ci/unit-tests-coverage/install

Looks like "--channel" doesn't work anymore ?

DEBUG=* ./node_modules/.bin/mozilla-download --product firefox \
                 --channel tinderbox \
                 --branch mozilla-central \
                 $PWD/firefox
usage: mozilla-download [-v] [--product PRODUCT] [--os OS] [--branch BRANCH]
                        [--debug DEBUG] [--file-suffix FILESUFFIX]
                        dest
mozilla-download: error: Unrecognized arguments: --channel /home/julien/travail/git/gaia/firefox.

Comment 10

[Aus Lacroix [:aus]]

Comment on attachment 8585738 [details] [review]
Pull request

Clearing flag since this has landed. Looks good, but yeah, --channel doesn't seem to work. Let's fix in a follow-up (or this bug if that's easier) and add a test for that scenario.

Comment 11

[Gareth Aye [:gaye] (back from PTO)]

Yeah channel isn't a thing anymore. The api is a bit different nowadays. You can specify a branch via --branch and it'll look through https://tools.taskcluster.net/index/artifacts/#buildbot.branches/buildbot.branches. You can also specify --product (firefox, b2g-desktop, or mulet). This was intentional but I think it could be useful for us to update the README.

Comment 12

[Julien Wajsberg [:julienw]]

Can I let one of you update the aforementioned scripts?

Comment 13

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...