1147112 - Add doorhanger icons

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

Need some resources from Anthony. This can optionally include the refactor that will abstract out the doorhanger resource that will just hold Icon, Content, and Buttons!

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Are these the icons that are in the 60dp container _inside_ each of the doorhangers?

Comment 2

[Chenxia Liu [:liuche]]

Yep!

Comment 3

[Chenxia Liu [:liuche]]

Hmm, I'm not sure where this should be set - there is a single location for doorhanger icons now, but we will need to differentiate between doorhangers somehow. Gecko obviously shouldn't know about this, so perhaps we can pass a type to Java, and let Java handle setting the icon.

Comment 4

[Chenxia Liu [:liuche]]

I saw these icons with my eyeballs. They exist.

Comment 5

[Chenxia Liu [:liuche]]

antlam, to start with, let's try these icons for these doorhangers (or some subset of them):
- Geolocation
- (update, or as is) Site Identity
- (update, or as is) Tracking protection
- Voice input (like Firefox Hello)

Comment 6

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_pack1.zip

Here's the first pack. It includes:

 - Geolocation (pin)
 - Secure site (green lock)
 - Tracking protection (updated)
 - Site ID (globe)

Missing: 
 - Media (video, audio, Firefox Hello etc)

Comment 7

[Chenxia Liu [:liuche]]

Tracking protection icon has changed, so need the updated icon for that.

Comment 8

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

^ that is already the updated TP apparently! (well done past me!)

But, I need to get you one with the "strike" through it.

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: icon_notTP.zip

Give these a try and see how they look. Icons for "not" Tracking protected.

Comment 10

[Chenxia Liu [:liuche]]

Antlam: we already seem to have a light globe icon in the tree (tab_panel_tab_globe http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-hdpi/tab_panel_tab_globe.png ). Should I replace that, use that, or just add a third globe icon? (There is also already a dark globe: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-hdpi/favicon_globe.png )

Comment 11

[Chenxia Liu [:liuche]]

Also, maybe we want to add a new lock_verified too? http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable-hdpi/lock_verified.png

It's used in the same place as lock_identified, which we're updating in this bug.

Comment 12

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Geolocation

This is the new geolocation doorhanger, with the icon. Our checkbox looks kind of weird, and the string is a little too long to not wrap (it truncates if we force singleLine).

Any thoughts on this? I'm also happy to leave Geolocation out of this set of icon changes.

Comment 13

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8632386 [details]
Screenshot: Geolocation

Yeah, I think you're right. Is this icon the right size? It looks a bit big as well. 

I can spec out how the line wraps for the "don't ask again for this site" string.

Comment 14

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Encrypted lock icon in Doorhanger

The icon is is the same size as the other icons in the pack, with the same padding. Here's the lock icon for comparison. Maybe the icons are bigger than, say, the key icon?

Comment 15

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Chenxia Liu [:liuche] from comment #14)
> Created attachment 8633002 [details]
> Screenshot: Encrypted lock icon in Doorhanger
> 
> The icon is is the same size as the other icons in the pack, with the same
> padding. Here's the lock icon for comparison. Maybe the icons are bigger
> than, say, the key icon?

Yeah that's definitely too big. It also looks like some upsizing is happening.. is it centered in a 60 dp square thats padding 20dp from the top and 10dp from the left?

Comment 16

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Encrypted lock icon in Doorhanger v2

Comment 17

[Chenxia Liu [:liuche]]

Attachment: Screenshot: Geolocation v2

Okay, I adjusted the padding and made the doorhangers not upscale the image anymore - how does this look?

Comment 18

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8633155 [details]
Screenshot: Geolocation v2

much better! + for icons!

Can we try to left align the check box with the left edge of "Share your location with www.google.com?"

Comment 19

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

^ Nevermind, spoke about this on IRC. WFM for now!

Comment 20

[Chenxia Liu [:liuche]]

url:        https://hg.mozilla.org/integration/fx-team/rev/f885136e35b35305a82aa1fe60f7b03b74b20404
changeset:  f885136e35b35305a82aa1fe60f7b03b74b20404
user:       Chenxia Liu <[e-mail]>
date:       Thu Jul 09 18:46:37 2015 -0700
description:
Bug 1147112 - Add doorhanger icons. r=ally

Comment 21

[Chenxia Liu [:liuche]]

The review for this is in bug 1175972, blame it on reviewboard.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f885136e35b3

Comment 23

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot from 2015-09-16 15:35:14.png

Verified as fixed using:
Device: Nexus 7 (Android 5.1)
Builds: Firefox for Android 43.0a1 (2015-09-15) and Firefox for Android 42.0a1 (2015-09-15)