Closed
Bug 1147123
Opened 8 years ago
Closed 8 years ago
[CDMA] Cannot merge 3-way call
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)
People
(Reporter: mschwart, Assigned: gsvelto)
References
Details
(Whiteboard: [caf priority: p2][CR 810202])
Attachments
(1 file, 1 obsolete file)
46 bytes,
text/x-github-pull-request
|
drs
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
STR: # Initiate a MO CDMA call # Add a new call Expected: Merge button should be available Observed: No merge or swap button is available This is a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=977588#c112
Updated•8 years ago
|
Whiteboard: [CR 810202]
Updated•8 years ago
|
Whiteboard: [CR 810202] → [caf priority: p2][CR 810202]
Comment 1•8 years ago
|
||
Comms triage: Regression from 2.1 on a use case which will impact CDMA phones
blocking-b2g: 2.2? → 2.2+
Assignee | ||
Comment 2•8 years ago
|
||
Taking this since I'm familiar with the topic.
Assignee: nobody → gsvelto
Updated•8 years ago
|
Target Milestone: --- → 2.2 S9 (3apr)
Reporter | ||
Comment 3•8 years ago
|
||
According to https://bugzilla.mozilla.org/show_bug.cgi?id=977588#c118 the mergeable/switchable flags from TelephonyCall should be used instead and these checks removed.
Comment 5•8 years ago
|
||
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8585765 [details] [review] [gaia] gabrielesvelto:bug-1147123-cdma-3way-merge > mozilla-b2g:master I can't test this patch since I don't have a CDMA device available and the emulator doesn't support it yet; but if the telephony code is doing its job properly on real devices this should work. I've removed tests that didn't make sense anymore and updated the remaining ones.
Attachment #8585765 -
Flags: review?(drs)
M4, could you please test the patch provided by Gabriele.
Flags: needinfo?(mschwart)
Comment 8•8 years ago
|
||
Comment on attachment 8585765 [details] [review] [gaia] gabrielesvelto:bug-1147123-cdma-3way-merge > mozilla-b2g:master See my comments on the PR. Would also like to get the results of partner testing before we land this.
Attachment #8585765 -
Flags: review?(drs) → review-
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8585765 [details] [review] [gaia] gabrielesvelto:bug-1147123-cdma-3way-merge > mozilla-b2g:master Addressed the review comments. I've moved around some tests and added more to better capture the changes I made. I hope this is good enough; I have to ask you to land this for me once it's r+'d and handle the upflit too.
Attachment #8585765 -
Flags: review- → review?(drs)
Updated•8 years ago
|
Attachment #8585765 -
Flags: review?(drs) → review+
Comment 10•8 years ago
|
||
Comment 11•8 years ago
|
||
Landed in https://github.com/mozilla-b2g/gaia/commit/95ffe46f9cd64b03d8f9bba0ac386942c2966f13 Same code as attachment 8585765 [details] [review], just squashed. https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=88f4f9f0007d6ff3fee1d63fa058f6100a4b2620
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → fixed
Resolution: --- → FIXED
Comment 12•8 years ago
|
||
Needinfo to request uplift. We should wait for M4's test results first, though.
Flags: needinfo?(drs)
Updated•8 years ago
|
Attachment #8586407 -
Attachment is obsolete: true
Reporter | ||
Comment 13•8 years ago
|
||
I can merge calls with this patch. I can't add another call once I'm in the conference state (someone has dropped off and I want to call them back) but that's another issue...
Flags: needinfo?(mschwart)
Comment 14•8 years ago
|
||
Doug, please uplift this patch to 2.2.
Comment 15•8 years ago
|
||
Comment on attachment 8585765 [details] [review] [gaia] gabrielesvelto:bug-1147123-cdma-3way-merge > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Incomplete functionality from bug 977588. [User impact] if declined: CDMA users will be unable to merge conference calls into 3-way calls. [Testing completed]: m4 tried this. See comment 13. [Risk to taking this patch] (and alternatives if risky): Medium as we can't test this ourselves since it's CDMA-only, and it's a fairly big patch, but there's no real alternative. [String changes made]: None.
Flags: needinfo?(drs)
Attachment #8585765 -
Flags: approval-gaia-v2.2?(bbajaj)
Updated•8 years ago
|
Flags: needinfo?(bbajaj)
Attachment #8585765 -
Flags: approval-gaia-v2.2?(bbajaj) → approval-gaia-v2.2+
Comment 17•8 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/c36202a8e01e2c250c91c3c64fd2ea81d7c61b98
You need to log in
before you can comment on or make changes to this bug.
Description
•