Closed Bug 1147132 Opened 7 years ago Closed 7 years ago

Keyboard covers top sites content

Categories

(Firefox for iOS :: Home screen, defect)

All
iOS 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

47 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
Hit this issue on a fresh profile with <6 total entries, with the phone in landscape mode. The keyboard covers the tiles, and trying to touch/scroll doesn't make it go away. Looks like there are a couple of problems:
1) Our collection view height calculation is wrong if there are <6 entries, which breaks scrolling.
2) Setting "keyboardDismissMode = .OnDrag" makes the keyboard go away if we scroll the view, but the view isn't scrollable if the content doesn't stretch beyond what's visible.
Blocks: 1130497
Summary: Keyboard covers to sites content → Keyboard covers top sites content
Attached file Pull request
Attachment #8582651 - Flags: review?(sarentz)
Comment on attachment 8582651 [details] [review]
Pull request

LGTM
Attachment #8582651 - Flags: review?(sarentz) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.