1147175 - Use SDWebImage for thumbnail

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Wesley Johnston (:wesj)]

I've wanted to use sdwebimage for this so that we don't wind up writing more disk and memory cache code (i.e. I'd rather have one set of code for it, and I'd rather not have to maintain it ourselves if we can).

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Pull request

This uses a "namespaced" SDWebImageCache object for storing these. That should allow us to delete them exclusively (we should also use this to keep favicons per-profile, I'll file a bug for that...)

Comment 2

[Wesley Johnston (:wesj)]

I updated this to address some questions. Using our own cache for it actually causes some problems. Namley, imageView.sd_loadFromUrl(...) won't look there! There's no good fix I could find, so I actually just forked the method into a new:

imageView.moz_loadFromCache(url, cache, completion)

method. Its drastically simplified, but works well for this simpler use case.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8582727 [details] [review]
Pull request

Mostly looks OK to me, with some questions about the keys we're using.

Comment 4

[Atul Aggarwal]

I see the pull request already merged into master branch and hence this bug might be no more valid now.

Comment 5

[Brian Nicholson (:bnicholson)]

Thanks, looks like we just forgot to close this.

https://github.com/mozilla/firefox-ios/commit/e31758fefdcaaa485e75e819d27c480e97774e45