1147226 - [EME] non MSE video errors out when media.eme.mse-only is true

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Regression from  Bug 1134434. If we load an EME video and media.eme.mse-only is true, we still error out.

EME in non-MSE video is officially unsupported, but since all Adobe's tests rely on it and the fix is simple and we're hustling to ship EME we don't want to add work on Adobe at this stage so we'll fix this issue.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Needs uplift.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3779bb7888d3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3779bb7888d3

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8582779 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: We only support EME inside MSE video, but Adobe's unit tests still use EME in non-MSE video. I don't want to disrupt Adobe's dev cycle, so we provide a pref for Adobe to use that makes EME work in non-MSE video so that their tests work. This broke (because our tests don't cover this case). I don't want to delay Adobe by breaking their tests, and without this uplifted, Adobe's unit tests (which use EME in non-MSE video) won't work in Firefox 38. 
[Describe test coverage new/current, TreeHerder]: Adobe's unit tests cover this. We deliberately don't cover this code path in our own code; it's for our partner's convenience.
[Risks and why]: Low; this code path is preffed off by default.
[String/UUID change made/needed]: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Bug 1134434 hasn't landed on Aurora.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8582779 [details] [diff] [review]
Patch

This missed the uplift to Aurora. It'll need to go through the Beta approval process.

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

As Ryan says, the regressor isn't in Firefox 38. So nothing more to do here.