Closed
Bug 1147255
Opened 11 years ago
Closed 11 years ago
There's a missing logger for webapi_logger_handler
Categories
(Firefox OS Graveyard :: Certification Suite, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: atsai, Assigned: oouyang)
References
Details
Attachments
(1 file)
https://github.com/mozilla-b2g/fxos-certsuite/blob/master/certsuite/cert.py#L80
There's a logger missing.
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → oouyang
| Assignee | ||
Comment 1•11 years ago
|
||
There should be an global 'logger' and it's set in 'cli' function and can be used in the 'webapi_log_handler' function.
The global 'logger' declare is missed.
| Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8582848 -
Flags: review?(fyen)
Attachment #8582848 -
Flags: review?(atsai)
Comment 3•11 years ago
|
||
Comment on attachment 8582848 [details] [review]
add global logger declare
LGTM
Attachment #8582848 -
Flags: review?(fyen) → review+
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 5•11 years ago
|
||
Comment on attachment 8582848 [details] [review]
add global logger declare
clean flag. thanks :D
Attachment #8582848 -
Flags: review?(atsai)
You need to log in
before you can comment on or make changes to this bug.
Description
•