If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Delete cached oauth tokens when Firefox Account is deleted

RESOLVED FIXED in Firefox 40

Status

Android Background Services
Reading List Sync
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: nalexander, Assigned: vivek, Mentored)

Tracking

unspecified
Firefox 40
All
Android

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

57 bytes, text/x-github-pull-request
nalexander
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
Using

https://github.com/mozilla/fxa-oauth-server/blob/master/docs/api.md#post-v1destroy
(Reporter)

Comment 1

3 years ago
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/receivers/FxAccountDeletedService.java#69
(Reporter)

Comment 2

3 years ago
(In reply to Nick Alexander :nalexander from comment #1)
> https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/fxa/
> receivers/FxAccountDeletedService.java#69

Could do delete tokens should go around here.
(Assignee)

Comment 3

3 years ago
Created attachment 8588686 [details] [review]
android-sync PR
Attachment #8588686 - Flags: review?(nalexander)
(Reporter)

Comment 4

3 years ago
Comment on attachment 8588686 [details] [review]
android-sync PR

Updated patch, one nit, and I think we're good.
Attachment #8588686 - Flags: review?(nalexander) → feedback+
(Assignee)

Comment 5

3 years ago
Created attachment 8590556 [details] [review]
android-sync PR

PR updated with review comments
Attachment #8588686 - Attachment is obsolete: true
Attachment #8590556 - Flags: review?(nalexander)
(Reporter)

Comment 6

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/82c4a7172cbe
(Reporter)

Updated

3 years ago
Assignee: nobody → vivekb.balakrishnan
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/82c4a7172cbe
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
(Reporter)

Comment 8

3 years ago
Comment on attachment 8590556 [details] [review]
android-sync PR

Landed.  Thanks vivek!
Attachment #8590556 - Flags: review?(nalexander) → review+
You need to log in before you can comment on or make changes to this bug.