1147283 - Replace mozpack.path with mozpath

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Replace mozpack.path with mozpath

Back when mozpack.path was added, it was used as:

  import mozpack.path
  mozpack.path.func()

Nowadays, the common idiom is:

  import mozpack.path as mozpath
  mozpath.func()

because it's shorter.

$ git grep mozpath\\. | wc -l
423
$ git grep mozpack.path\\. | wc -l
121

This change was done with:
$ git grep -l mozpack.path\\. | xargs sed -i 's/mozpack\.path\./mozpath./g'
$ git grep -l 'import mozpack.path$' | xargs sed -i 's/import mozpack.path$/\0 as mozpath/'
$ (pat='import mozpack.path as mozpath'; git grep -l "$pat" | xargs sed -i "1,/$pat/b;/$pat/d")

Comment 2

[Mike Hommey [:glandium]]

Attachment: Replace mozpack.path with mozpath

This was originally done on top of local changes to l10n.py that removed two uses of mozpack.path. Reordered my patch queue.

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8583465 [details] [diff] [review]
Replace mozpack.path with mozpath

>diff --git a/python/mozbuild/mozbuild/backend/mach_commands.py b/python/mozbuild/mozbuild/backend/mach_commands.py
>+import mozpack.path as mozpath

This one appears to be unused.

>diff --git a/python/mozbuild/mozpack/copier.py b/python/mozbuild/mozpack/copier.py
>     def match(self, pattern):
>         '''
>         Return the list of paths, stored in the container, matching the
>-        given pattern. See the mozpack.path.match documentation for a
>+        given pattern. See the mozpath.match documentation for a

Should the comments still reference mozpack.path.match? There's a few of these in a couple different files.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76d1fba1297a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76d1fba1297a

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8583465 [details] [diff] [review]
Replace mozpack.path with mozpath

Ah I missed this one, asking for approval because its required for bug 1147207. See approval comment there for reasoning.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8583465 [details] [diff] [review]
Replace mozpack.path with mozpath

Should be in 38 beta 3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d59b572e546f