1147311 - BG__migrateUI() should migrate font.language.group to a supported value

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Henri Sivonen (:hsivonen)]

Bug 756022 narrowed the permissible value space for the font.language.group pref which tracks the currently-chosen group in the font settings, but the patches didn't deal with font.language.group being left with an obsolete value.

BG__migrateUI() in nsBrowserGlue.js should be amended to check the value of font.language.group and, if the value is "tr", "x-baltic" or "x-central-euro", set the value to "x-western".

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Migrate the pref value if needed

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8583005 [details] [diff] [review]
Migrate the pref value if needed

Review of attachment 8583005 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/nsBrowserGlue.js
@@ +1962,5 @@
>        }
>      }
>  
> +    if (currentUIVersion < 28) {
> +      let group = null;    

some trailing spaces

@@ +1967,5 @@
> +      try {
> +        group = Services.prefs.getComplexValue("font.language.group",
> +                                               Ci.nsIPrefLocalizedString);
> +      } catch (ex) {}
> +      if (group.data == "tr" ||

null check group first

if (group &&
    ["tr", "x-baltic", "x-central-euro"].some(g => g == group.data)) {
...
}

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Migrate the pref value if needed, with review comments addressed

Thanks. Attaching a patch with the comments addressed.

Comment 4

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/180361c8634a

Rebased by hand to be migration 29 (instead of 28).

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/180361c8634a

Comment 6

[Henri Sivonen (:hsivonen)]

(In reply to Matthew N. [:MattN] from comment #4)
> https://hg.mozilla.org/integration/fx-team/rev/180361c8634a

Thanks.

> Rebased by hand to be migration 29 (instead of 28).

I was hoping this was upliftable to Aurora and Beta, since problem this patch addresses was introduced in Firefox 34. I guess fx-team taking 28 in the mean time makes uplifting too much trouble. :-( Or is there a good solution?

Comment 7

[Marco Bonardo [:mak]]

(In reply to Henri Sivonen (:hsivonen) from comment #6)
> I was hoping this was upliftable to Aurora and Beta, since problem this
> patch addresses was introduced in Firefox 34. I guess fx-team taking 28 in
> the mean time makes uplifting too much trouble. :-( Or is there a good
> solution?

the only solution would be to move migration 28 to migration 30 (it will run again but should not be an issue) in Nightly.