Closed Bug 1147325 Opened 5 years ago Closed 5 years ago

this._inspector.toolbox is null when running test browser_markupview_tag_edit_03.js

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox39 --- fixed

People

(Reporter: pbro, Assigned: bgrins)

References

Details

Attachments

(1 file)

I don't think this happened yesterday when I was working on this test (browser_markupview_tag_edit_03.js), so it must have been something that landed later in the day, perhaps bug 1139644.

In any case, it's not a big issue, just errors in the logs, the test still passes.
Here's the error:

console.error:
  Message: TypeError: this._inspector.toolbox is null
  Stack:
    MarkupView.prototype._hideBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:316:5
MarkupView.prototype._brieflyShowBoxModel/this._briefBoxModelTimer<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:331:7
notify@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/timers.js:40:9
I'm guessing the SDK setTimeout call still fires even after the markup view window was destroyed but the old setTimeout never did?  https://hg.mozilla.org/integration/fx-team/rev/fb06cbc42442#l1.121

We should probably be clearing any active timeouts throughout that file in relevant destroy functions.
This seems to do the trick.  Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b12e3f70e8e2
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8583264 - Flags: review?(pbrosset)
Blocks: 1139644
Comment on attachment 8583264 [details] [diff] [review]
clear-boxmodel-timer.patch

Review of attachment 8583264 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Looks good to me.
Attachment #8583264 - Flags: review?(pbrosset) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/36f19d3140ed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.