1147325 - this._inspector.toolbox is null when running test browser_markupview_tag_edit_03.js

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

I don't think this happened yesterday when I was working on this test (browser_markupview_tag_edit_03.js), so it must have been something that landed later in the day, perhaps bug 1139644.

In any case, it's not a big issue, just errors in the logs, the test still passes.
Here's the error:

console.error:
  Message: TypeError: this._inspector.toolbox is null
  Stack:
    MarkupView.prototype._hideBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:316:5
MarkupView.prototype._brieflyShowBoxModel/this._briefBoxModelTimer<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:331:7
notify@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/timers.js:40:9

Comment 1

[Brian Grinstead [:bgrins]]

I'm guessing the SDK setTimeout call still fires even after the markup view window was destroyed but the old setTimeout never did?  https://hg.mozilla.org/integration/fx-team/rev/fb06cbc42442#l1.121

We should probably be clearing any active timeouts throughout that file in relevant destroy functions.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: clear-boxmodel-timer.patch

This seems to do the trick.  Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b12e3f70e8e2

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8583264 [details] [diff] [review]
clear-boxmodel-timer.patch

Review of attachment 8583264 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Looks good to me.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/36f19d3140ed

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/36f19d3140ed