1147440 - Improve the transition of the Add to Reading List URL Button

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Michael Maslaney [:mmaslaney] ([e-mail])]

The Add to Reading List button in the URL bar appears jarring on hover. Let's smooth out the transition by adding in some minor easing.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Attachment: Add a transition to the reading list add/remove button.

How about something like this?  (Lemme know if you want a build with this patch to review…)

Comment 2

[Blake Winton (:bwinton) (:☕️)]

And I put the (OS X) build up at https://dl.dropboxusercontent.com/u/2301433/Firefox/Reading/UrlbarTransition.dmg

Comment 3

[Marco Mucci [:MarcoM]]

Hi Blake, can you provide a point value.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Sure.  One point!  :)

Comment 5

[Michael Maslaney [:mmaslaney] ([e-mail])]

Comment on attachment 8583195 [details] [diff] [review]
Add a transition to the reading list add/remove button.

I'm not seeing a transition. Is it very minor?

Comment 6

[Michael Maslaney [:mmaslaney] ([e-mail])]

Comment on attachment 8583195 [details] [diff] [review]
Add a transition to the reading list add/remove button.

Sorry, looking for the wrong transition. 

This is badass!

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8583195 [details] [diff] [review]
Add a transition to the reading list add/remove button.

Okay, over to Jared for the review…  (And there are another two coming.  :)

Comment 8

[Madhava Enros [:madhava]]

Woo!

Would we wan't to do anything on click as well? I.e to bring it into the family of transition effects like the star or the downloads arrow? Both of those move all over the place, which maybe we don't want to do here yet, but what about mimicking the grow/shrink of the bookmarks menu button (the one it uses when it receives a new bookmark)?

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Sounds like a pretty good plan to me.  I'll give it a try tomorrow, and see how distracting it is…

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Madhava Enros [:madhava] from comment #8)
> Would we wan't to do anything on click as well? I.e to bring it into the
> family of transition effects like the star or the downloads arrow? Both of
> those move all over the place, which maybe we don't want to do here yet, but
> what about mimicking the grow/shrink of the bookmarks menu button (the one
> it uses when it receives a new bookmark)?

This is bug 1131460, FWIW.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/98bca71c7758

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/98bca71c7758

Comment 13

[Blake Winton (:bwinton) (:☕️)]

Uplift request:

[User impact if declined]: There will be a more jarring transition when showing and hiding the reading list urlbar button.
[Describe test coverage new/current, TBPL]: Manual testing, and baking on mozilla-central for two days.
[Risks and why]: Low risk because its a very small CSS-only change.
[String/UUID change made/needed]: none

Comment 14

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 40.0a1 (2015-04-02), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Comment 15

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8583195 [details] [diff] [review]
Add a transition to the reading list add/remove button.

Approval Request Comment

See Comment 13.

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8583195 [details] [diff] [review]
Add a transition to the reading list add/remove button.

Low risk, we want Reading list to be polished, taking it.
Should be in 38 beta 2 or 3.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9e708c930a8f

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/05f716c8608d

Comment 19

[Andrei Vaida [:avaida]]

Verified fixed on Beta 38.0b2-build1 (20150406174117) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Comment 20

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Removing qe-verify flag as this was verified on Nightly and Beta, and won't be verified on 39 Aurora.