Closed Bug 1147440 Opened 10 years ago Closed 10 years ago

Improve the transition of the Add to Reading List URL Button

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
38 Branch
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 40
Iteration:
40.1 - 13 Apr
Tracking Flags:
Tracking Status
firefox38 --- verified
firefox39 --- fixed
firefox40 --- verified

People

(Reporter: mmaslaney, Assigned: bwinton)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Add a transition to the reading list add/remove button.
1.23 KB, patch
Unfocused
: review+
mmaslaney
: ui-review+
Sylvestre
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
The Add to Reading List button in the URL bar appears jarring on hover. Let's smooth out the transition by adding in some minor easing.
Flags: firefox-backlog+
How about something like this? (Lemme know if you want a build with this patch to review…)
Assignee: nobody → bwinton
Status: NEW → ASSIGNED
Attachment #8583195 - Flags: ui-review?(mmaslaney)
Hi Blake, can you provide a point value.
Blocks: 1132074
Iteration: --- → 39.3 - 30 Mar
Flags: qe-verify?
Flags: needinfo?(bwinton)
Sure. One point! :)
Points: --- → 1
Flags: needinfo?(bwinton)
Comment on attachment 8583195 [details] [diff] [review] Add a transition to the reading list add/remove button. I'm not seeing a transition. Is it very minor?
Comment on attachment 8583195 [details] [diff] [review] Add a transition to the reading list add/remove button. Sorry, looking for the wrong transition. This is badass!
Attachment #8583195 - Flags: ui-review?(mmaslaney) → ui-review+
Comment on attachment 8583195 [details] [diff] [review] Add a transition to the reading list add/remove button. Okay, over to Jared for the review… (And there are another two coming. :)
Attachment #8583195 - Flags: review?(jaws)
Woo! Would we wan't to do anything on click as well? I.e to bring it into the family of transition effects like the star or the downloads arrow? Both of those move all over the place, which maybe we don't want to do here yet, but what about mimicking the grow/shrink of the bookmarks menu button (the one it uses when it receives a new bookmark)?
Sounds like a pretty good plan to me. I'll give it a try tomorrow, and see how distracting it is…
status-firefox38: --- → affected
status-firefox39: --- → affected
Flags: qe-verify? → qe-verify+
QA Contact: andrei.vaida
(In reply to Madhava Enros [:madhava] from comment #8) > Would we wan't to do anything on click as well? I.e to bring it into the > family of transition effects like the star or the downloads arrow? Both of > those move all over the place, which maybe we don't want to do here yet, but > what about mimicking the grow/shrink of the bookmarks menu button (the one > it uses when it receives a new bookmark)? This is bug 1131460, FWIW.
Attachment #8583195 - Flags: review?(jaws) → review+
Keywords: checkin-needed
Iteration: 39.3 - 30 Mar → 40.1 - 13 Apr
https://hg.mozilla.org/mozilla-central/rev/98bca71c7758
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Uplift request: [User impact if declined]: There will be a more jarring transition when showing and hiding the reading list urlbar button. [Describe test coverage new/current, TBPL]: Manual testing, and baking on mozilla-central for two days. [Risks and why]: Low risk because its a very small CSS-only change. [String/UUID change made/needed]: none
Verified fixed on Nightly 40.0a1 (2015-04-02), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Comment on attachment 8583195 [details] [diff] [review] Add a transition to the reading list add/remove button. Approval Request Comment See Comment 13.
Attachment #8583195 - Flags: approval-mozilla-beta?
Attachment #8583195 - Flags: approval-mozilla-aurora?
Comment on attachment 8583195 [details] [diff] [review] Add a transition to the reading list add/remove button. Low risk, we want Reading list to be polished, taking it. Should be in 38 beta 2 or 3.
Attachment #8583195 - Flags: approval-mozilla-beta?
Attachment #8583195 - Flags: approval-mozilla-beta+
Attachment #8583195 - Flags: approval-mozilla-aurora?
Attachment #8583195 - Flags: approval-mozilla-aurora+
Target Milestone: Firefox 38 → Firefox 40
Verified fixed on Beta 38.0b2-build1 (20150406174117) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
status-firefox38: fixed → verified
Removing qe-verify flag as this was verified on Nightly and Beta, and won't be verified on 39 Aurora.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: