Closed
Bug 1147465
Opened 9 years ago
Closed 9 years ago
Messaging on the Fennec Stumbler checkbox: grammar fix
Categories
(Android Background Services Graveyard :: Geolocation, defect)
Tracking
(firefox39 fixed)
RESOLVED
FIXED
Firefox 39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: garvan, Assigned: garvan)
References
Details
Attachments
(1 file, 1 obsolete file)
4.77 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
Updating to match the recommendation here: +++ This bug was initially created as a clone of Bug #1107631 +++ -<!ENTITY data…_summary2 "Shares approximate Wi-Fi and cellular location of your device…"> +<!ENTITY data…_summary3 "…! Share approximate Wi-Fi and cellular location of your device…"> Share _the_ approximate … location of …, or Share approximate … location _info_ of …? (In reply to Garvan Keeley [:garvank] from comment #8) > The punctuation I copied from the Health Report :), so I didn't add the > period. I'm not sure what the right thing is here. I'd sure use a period, as this involves 2 sentences using imperative mood (tell the user to…). Please be punctual in using periods (and not), as it may affect l10n. Imperative and infinitive mood look similar in English and may be hard to distinguish, as opposed to several other locales. Using periods or not can be just as important in English for the same reason.
Attachment #8583162 -
Flags: review?(rnewman)
Attachment #8583162 -
Flags: feedback?(tonnes.mb)
Comment 2•9 years ago
|
||
Loks fine to me. We chose the other option for our locale in the previous version, but sharing the location itself makes more sense. Thanks!
Updated patch to pass robocop testing, and switching review from rnewman (25 reviews in queue!) to nick (3 in queue).
Attachment #8583281 -
Flags: review?(nalexander)
Attachment #8583162 -
Attachment is obsolete: true
Attachment #8583162 -
Flags: review?(rnewman)
Attachment #8583162 -
Flags: feedback?(tonnes.mb)
Comment 4•9 years ago
|
||
Comment on attachment 8583281 [details] [diff] [review] bug1147465_grammarfix.diff Review of attachment 8583281 [details] [diff] [review]: ----------------------------------------------------------------- wfm!
Attachment #8583281 -
Flags: review?(nalexander) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/78d5f88176ef
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
You need to log in
before you can comment on or make changes to this bug.
Description
•