1147535 - Update failure string in share overlay send tab failure

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Anthony Lam (:antlam) from bug 1130203 comment #56)
> Comment on attachment 8582770 [details]
> Failure toast
> 
> hm, that doesn't feel much like an "error"..
> 
> String change? "Sorry! Your tab could not be sent."

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I feel like we're not telling the user what to do about the problem.

How about, "Sorry! Your tab could not be sent. Please try again later."?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Anthony mentioned he the string works on irc.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1147535/mcomella

/r/6099 - Bug 1147535 - Update failure string in share overlay toast. r=liuche

Pull down this commit:

hg pull review -r 423985127a58f267860f08112c28f88af5e2edcb

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8583323 [details]
Screenshot

+!
small tweak, can we get a line break before the "call-to-action" (Please try again later)? :D

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

^For that matter, let's get rid of the "Sorry!" as well. It's not necessary now that we say "Please try again later."

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8583324 [details]
MozReview Request: bz://1147535/mcomella

/r/6099 - Bug 1147535 - Update failure string in share overlay toast. r=liuche

Pull down this commit:

hg pull review -r 74b25daa418c9a60066fde2b451789842a14287f

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8583324 [details]
MozReview Request: bz://1147535/mcomella

https://reviewboard.mozilla.org/r/6097/#review5101

Ship It!

::: mobile/android/base/locales/en-US/android_strings.dtd
(Diff revision 2)
> +     divided into two lines (use the newline escape character, "\n", between

Nit: missing closing paren

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/e88d6472a87f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e88d6472a87f

Comment 12

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1147535 - Update failure string in share overlay toast. r=liuche