1147588 - Convert MarkSlots family to TraceEdge

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: 4.3_slot_tracing-v0.diff

Trivial except for MarkObjectSlots, which I've skipped for now as it's going to require a bit more groundwork. Basically we want to get to a point where our tracers are self contained enough that we can make JS_TraceChildren explicitly take a CallbackTracer. This is already almost doable for object, so I don't think it will be too hard a few patches down the line.

Comment 1

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1216bd1e667e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a9d166af96b

https://hg.mozilla.org/integration/mozilla-inbound/rev/37c42cff2c01

Comment 2

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/99415fbccf83 because something in this push caused frequent 10.10 debug devtools-2 assertion failures like https://treeherder.mozilla.org/logviewer.html#?job_id=8197104&repo=mozilla-inbound

Comment 3

[Terrence Cole [:terrence]]

The problem before was in the last patch in the series (bug 1147670):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=514b9ba692a9
https://hg.mozilla.org/integration/mozilla-inbound/rev/a33d181b8d6a

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a33d181b8d6a