Closed Bug 1147648 Opened 5 years ago Closed 5 years ago

NotifyLayersUpdated does not update line or page scroll amounts

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file)

This is causing a test failure in test_wheel_default_action for scrolling while zoomed.
Attached patch fixSplinter Review
Attachment #8583404 - Flags: review?(botond)
Comment on attachment 8583404 [details] [diff] [review]
fix

Review of attachment 8583404 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/FrameMetrics.h
@@ +31,5 @@
> + * WARNING!!!! When adding new fields to FrameMetrics, the following places
> + * should be updated to account for the new field:
> + *    FrameMetrics::operator ==
> + *    AsyncPanZoomController::NotifyLayersUpdated
> + *    The ParamTraits specialization in GfxMessageUtils.h

Consider placing either the warning itself, or a message saying to look at the warning here, at the bottom of the class, which is where new fields are likely to be added.
Attachment #8583404 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/c3376e427908
https://hg.mozilla.org/mozilla-central/rev/07dc430fc6a0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.