1147648 - NotifyLayersUpdated does not update line or page scroll amounts

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

This is causing a test failure in test_wheel_default_action for scrolling while zoomed.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8583404 [details] [diff] [review]
fix

Review of attachment 8583404 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/FrameMetrics.h
@@ +31,5 @@
> + * WARNING!!!! When adding new fields to FrameMetrics, the following places
> + * should be updated to account for the new field:
> + *    FrameMetrics::operator ==
> + *    AsyncPanZoomController::NotifyLayersUpdated
> + *    The ParamTraits specialization in GfxMessageUtils.h

Consider placing either the warning itself, or a message saying to look at the warning here, at the bottom of the class, which is where new fields are likely to be added.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c3376e427908

w/ comment #2 addressed

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c3376e427908
https://hg.mozilla.org/mozilla-central/rev/07dc430fc6a0