1147668 - Correctly reflect "video" and "track" RequestContext values

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

Request.context can reflect "audio" and "video" separately, so we should split TYPE_MEDIA into two for this to be reflected correctly.

Comment 1

[(no longer active)]

(Forgot about "track")

Comment 2

[(no longer active)]

Attachment: Split nsIContentPolicy::TYPE_MEDIA into TYPE_AUDIO and TYPE_VIDEO and TYPE_TRACK so that Request.context can reflect the correct value

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8584726 [details] [diff] [review]
Split nsIContentPolicy::TYPE_MEDIA into TYPE_AUDIO and TYPE_VIDEO and TYPE_TRACK so that Request.context can reflect the correct value

>+  MOZ_ASSERT(IsHTMLElement(nsGkAtoms::audio) ||
>+             IsHTMLElement(nsGkAtoms::video));

Nit, You could use the rather nice helper method
IsAnyOfHTMLElements(nsGkAtoms::audio, nsGkAtoms::video);
Same also elsewhere.

Comment 4

[(no longer active)]

The new plan is to use the TYPE_INTERNAL_* content policy types I added in bug 1174307.

Comment 5

[(no longer active)]

Attachment: Correctly reflect video and track RequestContext values

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8622686 [details] [diff] [review]
Correctly reflect video and track RequestContext values

Oh, we map _INTERNAL_ to something else before calling CP

Comment 7

[(no longer active)]

(In reply to Olli Pettay [:smaug] from comment #6)
> Comment on attachment 8622686 [details] [diff] [review]
> Correctly reflect video and track RequestContext values
> 
> Oh, we map _INTERNAL_ to something else before calling CP

Yes, indeed.  This function provides the mapping: <https://hg.mozilla.org/integration/mozilla-inbound/file/b7e3bb16f653/dom/base/nsContentUtils.cpp#l7818>

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7210dfe7ad78

Comment 9

[(no longer active)]

This triggered an assertion, so I backed it out:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-linux64-debug/1434420561/mozilla-inbound_ubuntu64_vm-debug_test-mochitest-3-bm117-tests1-linux64-build320.txt.gz

Comment 10

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09bc59954db8

Comment 11

[(no longer active)]

(In reply to :Ehsan Akhgari (not reading bugmail, needinfo? me!) from comment #9)
> This triggered an assertion, so I backed it out:
> 
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-
> inbound-linux64-debug/1434420561/mozilla-inbound_ubuntu64_vm-debug_test-
> mochitest-3-bm117-tests1-linux64-build320.txt.gz

Bug 1175114 fixes this.  This patch can be relanded with that.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f46a712edf7e

Comment 13

[(no longer active)]

This was busted the second time as well.  Bug 1175299 fixes that.

Comment 14

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbeaa22dfafe

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28bbcf8f9e1a

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/28bbcf8f9e1a