Closed
Bug 1147686
Opened 10 years ago
Closed 10 years ago
Don't use mutableScript() to set script to null on lazy functions
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: bzbarsky, Unassigned)
References
Details
Attachments
(1 file)
|
5.86 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
Because that should really be asserting hasScript().
Flags: needinfo?
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?
|
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(shu)
|
||
Comment 1•10 years ago
|
||
Currently it's bananas because we could be handing out a LazyScript casted to a
HeapPtrScript.
Attachment #8583980 -
Flags: review?(terrence)
|
|
||
Updated•10 years ago
|
Flags: needinfo?(shu)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8583980 [details] [diff] [review]
Make mutableScript and only use it when hasScript.
Review of attachment 8583980 [details] [diff] [review]:
-----------------------------------------------------------------
Good find!
Attachment #8583980 -
Flags: review?(terrence) → review+
|
||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•