1147701 - Only download the jsshell when running jit tests

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Chris Manchester (limited bugmail, email directly)]

I was poking around the code that downloads tests and it looks like we're downloading the jsshell for every suite, but we don't need to.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/build/mozharness/file/28e8e8169134/scripts/desktop_unittest.py#l431 is what I mean. I'll write a patch for this if nobody tries to stop me.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=072e608adaed looking good so far.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: bz://1147701/chmanchester

/r/6189 - Bug 1147701 - Only download the jsshell when running jit tests.

Pull down this commit:

hg pull review -r ac12482caaa8b32ab06049aabd14300ddf1f3604

Comment 4

[Jordan Lund (:jlund)]

apologies for not getting to this yet. I am on point for merge & uplift release work so I won't be able to look into this until my EOD.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

This is a small optimization (and a small patch), nothing urgent here.

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8584191 [details]
MozReview Request: bz://1147701/chmanchester

https://reviewboard.mozilla.org/r/6187/#review5291

sweet. I'll trust in you to know we only need jsshel for jittest :)

sorry, I didn't realize it was a one liner. bad /me for not checking ahead of time.

nit: I try to go for code like `if self._query_specified_suites('jittest')` over the double negative `if self._query_specified_suites('jittest') is not None` but up to you.

Comment 7

[Chris Manchester (limited bugmail, email directly)]

https://hg.mozilla.org/build/mozharness/rev/43a0808e3c19

Comment 8

[Release Engineering SlaveAPI Service]

mozharness production tag moved to: https://hg.mozilla.org/build/mozharness/rev/production

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1147701 - Only download the jsshell when running jit tests.