1147938 - [STK] SET_UP_MENU cannot be replaced

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Carol Yang [:cyang]]

USAT GCF 27.22.4.8.1.1 (SET UP MENU, Replace and Remove Toolkit Menu)

Steps:
- SET UP MENU proactive command with “Item1”, “Item2”, “Item3”, “Item4”.
- Select “Item2”.
- SET UP MENU proactive command with “One”, “Two”.

Observation:
- Selecting “Item2” on the first menu triggers the second SET UP MENU proactive command, but the UI still shows the stale menu (“Item1”, “Item2”, “Item3”, “Item4”). It is only when I go back to ‘Settings’ and open the ‘Toolkit Menu’ again, that I see the current menu (“One”, “Two”).

Comment 1

[Carol Yang [:cyang]]

Hi Fernando,

Can you please take a look at this?

Note that if there was a SET_UP_MENU proactive command followed by a SELECT_ITEM, the menu will be updated. It is only an issue when one SET_UP_MENU is replaced by another SET_UP_MENU.

Our testers found this via GCF testing but I was able to reproduce it locally by treating SELECT_ITEM as if it was SET_UP_MENU, i.e. make typeOfCommand=37 even when it should be 36.

Thanks,
Carol

Comment 2

[howie [:howie]]

Hi Wesley, are you in charge of the STK and triage this? Thanks.

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Hi Carol,

Manuel had been working on this topic too (adding him to the loop); We'll try to check this.

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Very likely this will be a blocker, but would like to hear from devs first.
We're very close to FC date (April6th).

Comment 5

[Manuel Casas Barrado [:mancas]]

Hi Carol, can you provide us the commands you've used to test this feature?

Thanks

Comment 6

[shawn ku [:sku]]

Sean,
 Please help check this issue in parallel.

Comment 7

[shawn ku [:sku]]

Please help provide us device/radio log, we want to check the proactive command sequences and PDUs we got from rild/modem.

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to shawn ku [:sku] from comment #7)
> Please help provide us device/radio log, we want to check the proactive
> command sequences and PDUs we got from rild/modem.

Carol, 
Would you please shed the light here?

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Clear ni first. I will keep watching this.

Comment 10

[Carol Yang [:cyang]]

Attachment: Cannot perform STK menu replace

Hi all,

The PDUs come from the GCF spec 3GPP TS 51.010-4. But you can reproduce this without those specific PDUs. In case you want the exact PDUs, they are:

SET UP MENU proactive command with “Item1”, “Item2”, “Item3”, “Item4”:

D03B810301250082028182850C546F6F6C6B6974204D656E758F07014974656D20318F07024974656D20328F07034974656D20338F07044974656D2034

SET UP MENU proactive command with “One”, “Two”:

D023810301250082028182850C546F6F6C6B6974204D656E758F04114F6E658F041254776F

As I mentioned in comment 1 though, if you have a regular STK card that contains a few level of menus, you can easily reproduce by treating SELECT_ITEM like a SET_UP_MENU. Please see the attached video where to reproduce this issue, I hacked the code to do so.

Comment 11

[shawn ku [:sku]]

Sean, please help check comment 10 to see the raw PDUs for issue repo.

Comment 12

[Sean Lee [:seanlee][:weilonge]]

I am working on this already and will update information here if there is any.

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/master/Bug1147938 > mozilla-b2g:master

Comment 14

[Sean Lee [:seanlee][:weilonge]]

Hi Carol,

In this patch, the UI will be back to main menu of Settings app when receiving SET_UP_MENU proactive command.

Could you help to verify the patch attachment 8594647 [details] [review]?
Thanks a lot.

Comment 15

[Carol Yang [:cyang]]

(In reply to Sean Lee [:seanlee] from comment #14)
> Hi Carol,
> 
> In this patch, the UI will be back to main menu of Settings app when
> receiving SET_UP_MENU proactive command.
> 
> Could you help to verify the patch attachment 8594647 [details] [review]?
> Thanks a lot.

Hi Sean,

Thanks for the quick turnaround on the fix! I've applied the patch and did see what you had described here. Looks good to me.

Thanks,
Carol

Comment 16

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8594647 [details] [review]
[gaia] weilonge:seanlee/STK/master/Bug1147938 > mozilla-b2g:master

Hi Fernando,

Could you help to review my patch?
Thank you!

Comment 17

[Keven Kuo [:kkuo]]

Hi! Sean,

Since you are working on this case.
Over to you. Thanks

--
Keven

Comment 18

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/27d008de10e77f30a1ab2413bdd0cf7f07c92001
test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=45d1369a4c31030790a7cf5d0bb8bc46a1df741e

Comment 19

[Carol Yang [:cyang]]

Comment on attachment 8594647 [details] [review]
[gaia] weilonge:seanlee/STK/master/Bug1147938 > mozilla-b2g:master

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 20

[Carol Yang [:cyang]]

Hi Bhavna,

Can you please approve this for 2.2?

Thanks,
Carol

Comment 21

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8594647 [details] [review]
[gaia] weilonge:seanlee/STK/master/Bug1147938 > mozilla-b2g:master

Hi bhavana,

This is a gaia patch, so the approval should be approval‑gaia‑v2.2. could you give the approval again? Thank you!

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/STK/v2.2/Bug1147938 > mozilla-b2g:v2.2

Comment 23

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/67c6bb18e29f92ec2728d3713dcb5d265179b546