1148007 - Show Queue Tab toast only if Tab Queue preference is enabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martyn Haigh (:mhaigh)]

If the Tab Queue feature is not enabled then load an Intent with an ACTION_VIEW action normally, otherwise add to the Tab Queue .

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: Show Queue Tab toast only if Tab Queue preference is enabled

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8583986 [details] [diff] [review]
Show Queue Tab toast only if Tab Queue preference is  enabled

Review of attachment 8583986 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: mobile/android/base/tabqueue/TabQueueDispatcher.java
@@ +54,5 @@
>          }
>  
> +        boolean showOpenInBackgroundToast = GeckoSharedPrefs.forApp(this).getBoolean(GeckoPreferences.PREFS_TAB_QUEUE, false);
> +
> +        if (showOpenInBackgroundToast) {

nit: -> shouldShowOpenInBackgroundToast

If you don't like this style of boolean naming, just let me know and I'll stop mentioning it. :)

Comment 3

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/dd175e539eac

Comment 4

[Teodora Vermesan (:TeoVermesan)]

With "open multiple links" pref disabled, opening a link from gmail will pop-up a "Complete action using" dialog and after choosing Nightly, the link will open in Nightly.
With "open multiple links" pref enabled,opening a link from gmail will pop-up a "Complete action using" dialog and after choosing Nightly, "Tab queued in Nightly | Open Now" notification appears.

Verified as fixed using:
Device: Samsung s5 (Android 4.4.4)
Build: Firefox for Android 41.a1 (2015-05-27)