1148016 - Without the signing warnings present we should pref off the changes in bug 1139656

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

[Tracking Requested - why for this release]:

The new install flow in bug 1139656 is simpler and has less warnings because the intention is that it is shown for add-ons that are signed by Mozilla, anything not signed should show a warning before installing or later refuse to install. Until we have that functionality we shouldn't let bug 1139656 get to release so we should pref it off in aurora.

Comment 1

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Tracking for 39. 

Dave, does this mean pref it off when 39 moves to aurora, or before it moves from aurora to beta? 
Can you take this or find a good owner for it?  Thanks!

Comment 2

[Dão Gottwald [::dao]]

Attachment: part 2: flip xpinstall.customConfirmationUI (aurora only)

(In reply to Liz Henry (:lizzard) from comment #1)
> Tracking for 39. 
> 
> Dave, does this mean pref it off when 39 moves to aurora, or before it moves
> from aurora to beta?

Once 39 is on aurora, i.e. now, I would say.

Comment 3

[Dave Townsend [:mossop]]

Yeah, pref this off on aurora until at least bug 1148021 is fixed.

Comment 4

[Dão Gottwald [::dao]]

I don't think I can land this as is, because I hadn't modified browser_bug553455.js with the expectation that we'd want to disable bug 1139656 on aurora, so that test will fail all over the place. The pref was mainly meant to serve as a per-application switch :/

Comment 5

[Dave Townsend [:mossop]]

(In reply to Dão Gottwald [:dao] from comment #4)
> I don't think I can land this as is, because I hadn't modified
> browser_bug553455.js with the expectation that we'd want to disable bug
> 1139656 on aurora, so that test will fail all over the place. The pref was
> mainly meant to serve as a per-application switch :/

Right yes. I guess an alternative would be to just implement bug 1148021 ignoring the fact that we can't tell if an add-on is Mozilla signed or not yet and just warn for every add-on (since none can actually be signed at the moment anyway).

Comment 6

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Sorry for the flag-twiddling. Untracking for 39!

Comment 7

[Dão Gottwald [::dao]]

Attachment: part 1: make browser_bug553455.js handle xpinstall.customConfirmationUI=false

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8589598 [details] [diff] [review]
part 1: make browser_bug553455.js handle xpinstall.customConfirmationUI=false

Review of attachment 8589598 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thanks. We should land this on trunk and aurora in case we miss 40 with this.

Comment 9

[Dão Gottwald [::dao]]

https://hg.mozilla.org/integration/fx-team/rev/5a5243c9e021

Comment 10

[Dão Gottwald [::dao]]

Dammit. There was a typo that unfortunately didn't make the test fail when run on its own.

backout:
https://hg.mozilla.org/integration/fx-team/rev/09b8d70e69fb

new attempt:
https://hg.mozilla.org/integration/fx-team/rev/1c7783c64f51

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1c7783c64f51

Comment 12

[Dão Gottwald [::dao]]

Comment on attachment 8589598 [details] [diff] [review]
part 1: make browser_bug553455.js handle xpinstall.customConfirmationUI=false

https://hg.mozilla.org/releases/mozilla-aurora/rev/9dd03bf49426

Comment 13

[Dão Gottwald [::dao]]

Comment on attachment 8586262 [details] [diff] [review]
part 2: flip xpinstall.customConfirmationUI (aurora only)

Approval Request Comment
[Feature/regressing bug #]: bug 1139656
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: covered by browser_bug553455.js which I updated earlier in this bug to deal with both pref states
[Risks and why]: pref switch, low risk
[String/UUID change made/needed]: none

Comment 14

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8586262 [details] [diff] [review]
part 2: flip xpinstall.customConfirmationUI (aurora only)

Approved for aurora uplift.

Comment 15

[Dão Gottwald [::dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8950cd69d6e3