Closed Bug 1148016 Opened 6 years ago Closed 6 years ago

Without the signing warnings present we should pref off the changes in bug 1139656

Categories

(Toolkit :: Add-ons Manager, defect)

39 Branch
defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.1 - 13 Apr
Tracking Status
firefox39 --- fixed
firefox40 + fixed

People

(Reporter: mossop, Assigned: dao)

References

Details

Attachments

(2 files)

[Tracking Requested - why for this release]:

The new install flow in bug 1139656 is simpler and has less warnings because the intention is that it is shown for add-ons that are signed by Mozilla, anything not signed should show a warning before installing or later refuse to install. Until we have that functionality we shouldn't let bug 1139656 get to release so we should pref it off in aurora.
Tracking for 39. 

Dave, does this mean pref it off when 39 moves to aurora, or before it moves from aurora to beta? 
Can you take this or find a good owner for it?  Thanks!
Flags: needinfo?(dtownsend)
(In reply to Liz Henry (:lizzard) from comment #1)
> Tracking for 39. 
> 
> Dave, does this mean pref it off when 39 moves to aurora, or before it moves
> from aurora to beta?

Once 39 is on aurora, i.e. now, I would say.
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #8586262 - Flags: review?(dtownsend)
Iteration: --- → 40.1 - 13 Apr
Points: --- → 1
Flags: qe-verify-
Flags: firefox-backlog+
Version: Trunk → 39 Branch
Attachment #8586262 - Flags: review?(dtownsend) → review+
Yeah, pref this off on aurora until at least bug 1148021 is fixed.
Flags: needinfo?(dtownsend)
I don't think I can land this as is, because I hadn't modified browser_bug553455.js with the expectation that we'd want to disable bug 1139656 on aurora, so that test will fail all over the place. The pref was mainly meant to serve as a per-application switch :/
(In reply to Dão Gottwald [:dao] from comment #4)
> I don't think I can land this as is, because I hadn't modified
> browser_bug553455.js with the expectation that we'd want to disable bug
> 1139656 on aurora, so that test will fail all over the place. The pref was
> mainly meant to serve as a per-application switch :/

Right yes. I guess an alternative would be to just implement bug 1148021 ignoring the fact that we can't tell if an add-on is Mozilla signed or not yet and just warn for every add-on (since none can actually be signed at the moment anyway).
Sorry for the flag-twiddling. Untracking for 39!
Attachment #8586262 - Attachment description: patch → part 2: flip xpinstall.customConfirmationUI (aurora only)
Comment on attachment 8589598 [details] [diff] [review]
part 1: make browser_bug553455.js handle xpinstall.customConfirmationUI=false

Review of attachment 8589598 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thanks. We should land this on trunk and aurora in case we miss 40 with this.
Attachment #8589598 - Flags: review?(dtownsend) → review+
Dammit. There was a typo that unfortunately didn't make the test fail when run on its own.

backout:
https://hg.mozilla.org/integration/fx-team/rev/09b8d70e69fb

new attempt:
https://hg.mozilla.org/integration/fx-team/rev/1c7783c64f51
https://hg.mozilla.org/mozilla-central/rev/1c7783c64f51
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8589598 [details] [diff] [review]
part 1: make browser_bug553455.js handle xpinstall.customConfirmationUI=false

https://hg.mozilla.org/releases/mozilla-aurora/rev/9dd03bf49426
Attachment #8589598 - Flags: checkin+
Comment on attachment 8586262 [details] [diff] [review]
part 2: flip xpinstall.customConfirmationUI (aurora only)

Approval Request Comment
[Feature/regressing bug #]: bug 1139656
[User impact if declined]: see comment 0
[Describe test coverage new/current, TreeHerder]: covered by browser_bug553455.js which I updated earlier in this bug to deal with both pref states
[Risks and why]: pref switch, low risk
[String/UUID change made/needed]: none
Attachment #8586262 - Flags: approval-mozilla-aurora?
Comment on attachment 8586262 [details] [diff] [review]
part 2: flip xpinstall.customConfirmationUI (aurora only)

Approved for aurora uplift.
Attachment #8586262 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.