1148047 - Emulator DTMF support

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

We need to support DTMF on the emulator to write tests for bug 1148036. We are currently getting "Error RequestNotSupported".

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 2: Modem

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Part 1: Reference RIL

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8584718 [details] [review]
Part 2: Modem

Hi Aknow, please help review this, thank you.

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8584718 [details] [review]
Part 2: Modem

left comments on github

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8584721 [details] [review]
Part 1: Reference RIL

left comments on github

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8584721 [details] [review]
Part 1: Reference RIL

Thanks for your feedback, I've just updated the PRs.

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8584721 [details] [review]
Part 1: Reference RIL

Awesome! Thank you for the work.
I had one comment on github.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Thanks!

Part 1: https://github.com/mozilla-b2g/platform_hardware_ril/commit/c0bf1eec60644abbc5e72c251c15092b4c71b6a9
Part 2: https://github.com/mozilla-b2g/platform_external_qemu/commit/a89cebcccc1e067ebdb71a93194f4ee79d71bd69