1148052 - Improve the transition of the type control menu

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect, P4)

Description

[Michael Maslaney [:mmaslaney] ([e-mail])]

If we're able, we should add some easing in to the Type Control, when clicked. I'm thinking some easing in and out with a slight bounce, if possible?

Comment 1

[lekhikadugtal]

As suggested by gijs, I would like to work on this issue.

Comment 2

[lekhikadugtal]

Gijs, So The required transistion for type-control menu is kinda like easing in/out ?

Comment 3

[:Gijs (he/him)]

(In reply to lekhikadugtal from comment #2)

Gijs, So The required transistion for type-control menu is kinda like easing in/out ?

There are existing animations for panels in the main Firefox interface, I think the easiest would be to mirror those. The animations are specificied here: https://searchfox.org/mozilla-central/source/toolkit/content/xul.css#367-386 with a fade and transform. The transform should probably be side-to-side for the reader mode panel. The CSS would have to live in toolkit/themes/shared/aboutReader.css .

Comment 4

[lekhikadugtal]

(In reply to :Gijs (he/him) from comment #3)

(In reply to lekhikadugtal from comment #2)

Gijs, So The required transistion for type-control menu is kinda like easing in/out ?

There are existing animations for panels in the main Firefox interface, I think the easiest would be to mirror those. The animations are specificied here: https://searchfox.org/mozilla-central/source/toolkit/content/xul.css#367-386 with a fade and transform. The transform should probably be side-to-side for the reader mode panel. The CSS would have to live in toolkit/themes/shared/aboutReader.css .

Thanks Gijs. I'll go through it :). Where can I contact you regarding some doubts ? Is it irc.

Comment 5

[lekhikadugtal]

Hi gijs, How about a horizontal side move of popup from left ?
And when the icon type-control will be clicked again. It would close by horizontal right move.

Comment 6

[lekhikadugtal]

Or We can try for fade-slide animation.

Comment 7

[:Gijs (he/him)]

(In reply to lekhikadugtal from comment #4)

Thanks Gijs. I'll go through it :). Where can I contact you regarding some doubts ? Is it irc.

IRC works, email works, bugzilla is probably best though.

(In reply to lekhikadugtal from comment #5)

Hi gijs, How about a horizontal side move of popup from left ?
And when the icon type-control will be clicked again. It would close by horizontal right move.

Yeah, so, like I said, I think we should go for the same animations as the main panels in Firefox, which use a combination of fading and sliding. In the case of these panels, we should use a horizontal slide instead of the vertical one that the panels in the main part of Firefox use.

Comment 8

[lekhikadugtal]

How to visibly see the change in css. Do we need to build it again or is it fine to restart it again. As i tried doing some changes but I can't seem to notice the change wile running.

Comment 9

[lekhikadugtal]

Hi Gijs, I've implemented the changes required for this bug. Now I wanted to ask, about patch as I saw that it should from phabricator instead of bugzilla.

Comment 10

[lekhikadugtal]

Attachment: Bug 1148052 - Add the trasition for type-control in Reader Mode.

Comment 11

[:Gijs (he/him)]

(I've responded to your questions in phabricator, I believe)

Comment 12

[:Gijs (he/him)]

We changed the design of reader mode, so this bug is probably no longer current.