1148156 - Print the window ID in the ++--DOMWINDOW logging

Status: REOPENED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

This should be useful for relating the what the CC logs to when the window was created.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Print the window ID in the ++--DOMWINDOW logging.

The DOMWINDOW leak detector doesn't care about extra stuff so this should be okay for that.

I don't know of anything else that depends on this.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8006219b661c

Comment 2

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=8278604&repo=mozilla-inbound

Comment 3

[Andrew McCreight [:mccr8]]

03:47:34 INFO - /builds/slave/m-in-l64-d-0000000000000000000/build/src/dom/base/nsGlobalWindow.cpp: In constructor 'nsGlobalWindow::nsGlobalWindow(nsGlobalWindow*)':
03:47:34 INFO - /builds/slave/m-in-l64-d-0000000000000000000/build/src/dom/base/nsGlobalWindow.cpp:1209:29: error: format '%llu' expects argument of type 'long long unsigned int', but argument 7 has type 'uint64_t {aka long unsigned int}' [-Werror=format]
03:47:34 INFO - /builds/slave/m-in-l64-d-0000000000000000000/build/src/dom/base/nsGlobalWindow.cpp: In destructor 'virtual nsGlobalWindow::~nsGlobalWindow()':
03:47:34 INFO - /builds/slave/m-in-l64-d-0000000000000000000/build/src/dom/base/nsGlobalWindow.cpp:1304:29: error: format '%llu' expects argument of type 'long long unsigned int', but argument 8 has type 'uint64_t {aka long unsigned int}' [-Werror=format]

I guess my test run was on 32-bit, and my local build doesn't have warnings as errors or something.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5e560350ca2

Comment 5

[Carsten Book [:Tomcat]]

(In reply to Carsten Book [:Tomcat] from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f5e560350ca2 note that was backedout, was just running the mcmerge tool again to remove the c-n keyword

Comment 6

[Andrew McCreight [:mccr8]]

This wouldn't be a bad thing to have, but clearly it isn't a very high priority for me.

Comment 7

[Andrew McCreight [:mccr8]]

I'm just going to close this for now.

Comment 8

[Andrew McCreight [:mccr8]]

Kris has mentioned this recently. It is still annoying when trying to investigate leaks. Right now, it prints out the serial number, which I guess is a counter for the total number of inner and outer windows that we have opened, which is sort of interesting, but maybe we could just only print out the window id in its place.