Closed
Bug 1148163
Opened 10 years ago
Closed 8 years ago
Clean up cc-analyzer.js
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(2 files)
2.54 KB,
patch
|
Details | Diff | Splinter Review | |
3.83 KB,
patch
|
Details | Diff | Splinter Review |
Right now, this creates a JS version of the entire CC graph, but most of that information is not needed. All the CC leak analyzer actually needs is a list of nsGlobalWindows that are not garbage, and their description, so it can extract the window id. This cleanup isn't strictly needed, but it makes dealing with the file nicer.
Assignee | ||
Comment 1•10 years ago
|
||
The CC analyzer looks for non-garbage nsGlobalWindows in the CC graph.
To do this, it needs to store a list of CC objects (along with their
description and whether they are garbage or not). Right now, the CC
analyzer is very general and stores its own copy of the entire graph,
but this generality hasn't been used in the last few years, so I think
it is reasonable to remove that to make things simpler. processingCount
isn't used at all. That's what part 1 does.
Right now, the CC stores every CC thing it sees, then looks through
them all after the fact for ones matching a particular string. Part 2
changes this so we store the string we're interested in, and only adds
things that match. This should greatly reduce how much we store.
try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8006219b661c
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
I'm just going to remove the CCAnalyzer.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•