1148182 - Re-enable testSecNotification and make the expired tests work with the new domain

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Syd Polk :sydpolk]

The expired certificate domain has been updated. This BZ is to change the test domain and re-enable these tests.

The domain has change from "summitbook.mozilla.org" to "ssl-expired.mozqa.com".



+++ This bug was initially created as a clone of Bug #1146314 +++

This test failure started to happen over the weekend and totally breaks our tests across Nightly, and Aurora so far. I haven't tested with beta and release yet.

ERROR | Test Failure | {
  "fail": {
    "message": "The error code is a SEC Expired certificate error - 'summitbook.mozilla.org uses an invalid security certificate.\n\nThe certificate is not trusted because the issuer certificate is unknown.\nThe server might not be sending the appropriate intermediate certificates.\nAn additional root certificate may need to be imported.\nThe certificate expired on 7/8/2011 5:41 AM. The current time is 3/22/2015 6:57 AM.\n\n(Error code: sec_error_unknown_issuer)\n' should contain 'sec_error_expired_certificate'", 
    "fileName": "file:///c:/jenkins/workspace/mozilla-central_remote/data/mozmill-tests/firefox/tests/remote/testSecurity/testSecurityNotification.js", 
    "name": "testSecNotification", 
    "lineNumber": 70
  }

Comment 1

[Syd Polk :sydpolk]

Attachment: diff.out

Change domain. Re-enable tests.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8584129 [details] [diff] [review]
diff.out

Review of attachment 8584129 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/testSecurityNotification.js
@@ +45,5 @@
>    expect.waitFor(function () {
>      return identityBox.getNode().className === "unknownIdentity";
>    }, "Identity is unknown");
>  
> +  // Bug 1106077 - Broken root certificate for http://summitbook.mozilla.org

Nit: the comment on this line can be removed now.

Comment 3

[Syd Polk :sydpolk]

https://hg.mozilla.org/qa/mozmill-tests/rev/4f00c3e26248

Comment 4

[Syd Polk :sydpolk]

https://hg.mozilla.org/qa/mozmill-tests/rev/9faa708fc610

Comment 5

[Syd Polk :sydpolk]

I will check the mozmill run tomorrow before marking this as fixed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Syd, FYI we usually continue to work on the original filed bug. I have CC'ed you on that one and also mentioned it on IRC. So this would have been bug 1146314.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 8584129 [details] [diff] [review]
diff.out

Review of attachment 8584129 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/testSecurityNotification.js
@@ +45,5 @@
>    expect.waitFor(function () {
>      return identityBox.getNode().className === "unknownIdentity";
>    }, "Identity is unknown");
>  
> +  // Bug 1106077 - Broken root certificate for http://summitbook.mozilla.org

FYI the comment has not been removed before landing the patch. But it's not important enough for any follow-up work.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

The landed changes in comment 3 and comment 4 fixed the problem for 38 and 39. So we can mark this bug as fixed.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: securitynotfication

This was not fixed for the esr31 branch and caused massive failures for the last full testrun 2 days ago. For that branch we only have to exchange the domain. That's all. So I think no review is necessary.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

https://hg.mozilla.org/qa/mozmill-tests/rev/1f7d68367e3c (esr31)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Not sure why but this is not fixed on esr31 when the tests get run via Mozmill CI:
http://hg.mozilla.org/qa/mozmill-tests/file/14e66857901d16c351e554d77adf4e76bbf25fed/firefox/tests/remote/testSecurity/testSecurityNotification.js

The domain is still the old one. While latest esr31 shows the correct domain. I will investigate soon.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Please disregard my last comment. I landed the skip on May 6th while the last esr release tests were on May 5th. So all good here.