Closed Bug 1148200 Opened 5 years ago Closed 4 years ago

Move isJSONable to sdk/lang/type

Categories

(Add-on SDK Graveyard :: General, defect, P3)

x86
macOS
defect

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: evold, Assigned: louischan0325)

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

The isJSONable function in sdk/content/loader should be moved to sdk/lang/type and have tests added for it.
Priority: -- → P3
Whiteboard: [good first bug]
Comment on attachment 8728437 [details]
MozReview Request: Bug 1148200 - Move isJSONable to sdk/lang/type.

Patch previously attached as a github PR [1] by a contributor [2]:

the change (which still applies cleanly) turns a previously private helper into an exported method of the "sdk/land/type" module and adds new tests for it (which I tried to run locally and they ran successfully).

[1]: https://github.com/mozilla/addon-sdk/pull/2033
[2]: the author metadata has been preserved into the patch submitted to mozreview
Attachment #8728437 - Flags: feedback+
Comment on attachment 8728437 [details]
MozReview Request: Bug 1148200 - Move isJSONable to sdk/lang/type.

added r? assigned to Dave for a final review on this patch.
Attachment #8728437 - Flags: review?(dtownsend)
Comment on attachment 8728437 [details]
MozReview Request: Bug 1148200 - Move isJSONable to sdk/lang/type.

https://reviewboard.mozilla.org/r/38945/#review35923
Attachment #8728437 - Flags: review?(dtownsend) → review+
Issue assigned to the contributor and added checkin-needed keyword.
Assignee: nobody → louischan0325
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b9c1e46c0033
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.