1148200 - Move isJSONable to sdk/lang/type

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

The isJSONable function in sdk/content/loader should be moved to sdk/lang/type and have tests added for it.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: MozReview Request: Bug 1148200 - Move isJSONable to sdk/lang/type.

Review commit: https://reviewboard.mozilla.org/r/38945/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/38945/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8728437 [details]
MozReview Request: Bug 1148200 - Move isJSONable to sdk/lang/type.

Patch previously attached as a github PR [1] by a contributor [2]:

the change (which still applies cleanly) turns a previously private helper into an exported method of the "sdk/land/type" module and adds new tests for it (which I tried to run locally and they ran successfully).

[1]: https://github.com/mozilla/addon-sdk/pull/2033
[2]: the author metadata has been preserved into the patch submitted to mozreview

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8728437 [details]
MozReview Request: Bug 1148200 - Move isJSONable to sdk/lang/type.

added r? assigned to Dave for a final review on this patch.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8728437 [details]
MozReview Request: Bug 1148200 - Move isJSONable to sdk/lang/type.

https://reviewboard.mozilla.org/r/38945/#review35923

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Issue assigned to the contributor and added checkin-needed keyword.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/b9c1e46c0033

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9c1e46c0033