Closed Bug 1148205 Opened 9 years ago Closed 5 years ago

Update attribute names for `hostname` and `formSubmitURL` in nsILoginInfo

Categories

(Toolkit :: Password Manager, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: tanvi, Assigned: MattN)

References

Details

(Whiteboard: [passwords:tech-debt])

Attachments

(6 files)

hostname is actually an origin not just the hostname.  And formSubmitURL is also an origin, not a full url.

May also be nice to make these nsIURI's so we can more easily access and modify parts of them.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/nsILoginInfo.idl#14
I think one of the reasons why we kept these names is for add-on compatibility.

If at some point we decide we care less about add-on compatibility, I think these renames are a good idea, and I look forward to when we will be able to make the logins simple JavaScript objects instead of XPCOM objects.

For the nsIURI part, I think the recent trend has been to switch away from nsIURI towards well-formed URI spec strings. One of the issues with how hostname and fromSubmitURL are defined now is that they don't have the trailing slash, though.
I think this is somewhere between WONTFIX and very very low priority.
Priority: -- → P5
Whiteboard: [passwords:tech-debt]
See Also: → 1413451

It seems like we don't have a better type for origins and usually use strings so I'll just rename them.

I'll leave storage and sync records alone to not break compatibility. I'll also leave getters with the old names for compatibility with Lockwise and TB.

Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Summary: Update names and types for hostname and formSubmitURL in nsILoginInfo → Update attributes names for `hostname` and `formSubmitURL` in nsILoginInfo

Leave getters for the old attribute names to not break compatibility with Sync data and Thunderbird.
Storage (and sync records) will continue using the old names.

Summary: Update attributes names for `hostname` and `formSubmitURL` in nsILoginInfo → Update attribute names for `hostname` and `formSubmitURL` in nsILoginInfo
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/d80312b41cd4
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in passwordmgr. r=sfoster,jaws
https://hg.mozilla.org/integration/autoland/rev/ea236d72325d
Replace misnamed `formSubmitURL` and `hostname` properties in toolkit/ tests. r=jaws
https://hg.mozilla.org/integration/autoland/rev/bae062fca494
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in browser/. r=jaws,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/b071db6bea7a
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/sync/ r=markh,tcsc
https://hg.mozilla.org/integration/autoland/rev/847445b24636
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/fxaccounts/ r=vladikoff
https://hg.mozilla.org/integration/autoland/rev/65104032313d
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in mobile/. r=Grisha

Hi Jared, is there any web platform-related documentation to do with regards to this bug?

Flags: needinfo?(jhirsch)

No, I think he was referring to https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsILoginInfo which I kinda want to delete so people rely on the .idl docs.

MattN's correct, I was thinking of the XPCOM IDL docs on MDN.

Flags: needinfo?(jhirsch)

OK, thanks folks.

No, I think he was referring to https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsILoginInfo which I kinda want to delete so people rely on the .idl docs.

We are aiming to get rid of such docs off MDN, starting around Q4 this year. We'll probably dump the raw HTML for them in a GitHub repo somewhere, so they are accessible if someone desparately needs something out of them.

Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: