1148205 - Update attribute names for `hostname` and `formSubmitURL` in nsILoginInfo

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P5)

Description

[Tanvi Vyas[:tanvi]]

hostname is actually an origin not just the hostname.  And formSubmitURL is also an origin, not a full url.

May also be nice to make these nsIURI's so we can more easily access and modify parts of them.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/passwordmgr/nsILoginInfo.idl#14

Comment 1

[:Paolo Amadini]

I think one of the reasons why we kept these names is for add-on compatibility.

If at some point we decide we care less about add-on compatibility, I think these renames are a good idea, and I look forward to when we will be able to make the logins simple JavaScript objects instead of XPCOM objects.

For the nsIURI part, I think the recent trend has been to switch away from nsIURI towards well-formed URI spec strings. One of the issues with how hostname and fromSubmitURL are defined now is that they don't have the trailing slash, though.

Comment 2

[Justin Dolske [:Dolske]]

I think this is somewhere between WONTFIX and very very low priority.

Comment 3

[Matthew N. [:MattN]]

It seems like we don't have a better type for origins and usually use strings so I'll just rename them.

I'll leave storage and sync records alone to not break compatibility. I'll also leave getters with the old names for compatibility with Lockwise and TB.

Comment 4

[Matthew N. [:MattN]]

Try push with only android failures which I'm fixing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f154f6d6003053c81d3f49bbebb1266dd5ddfcd5

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in passwordmgr. r=sfoster,jaws

Leave getters for the old attribute names to not break compatibility with Sync data and Thunderbird.
Storage (and sync records) will continue using the old names.

Comment 6

[Matthew N. [:MattN]]

Attachment: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties in toolkit/ tests. r=jaws

Depends on D33342

Comment 7

[Matthew N. [:MattN]]

Attachment: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in browser/. r=jaws

Depends on D33344

Comment 8

[Matthew N. [:MattN]]

Attachment: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/sync/ r=markh,tcsc

Depends on D33346

Comment 9

[Matthew N. [:MattN]]

Attachment: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/fxaccounts/ r=vladikoff

Depends on D33347

Comment 10

[Matthew N. [:MattN]]

Attachment: Bug 1148205 - Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in mobile/. r=liuche,grisha

Depends on D33348

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d80312b41cd4
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in passwordmgr. r=sfoster,jaws
https://hg.mozilla.org/integration/autoland/rev/ea236d72325d
Replace misnamed `formSubmitURL` and `hostname` properties in toolkit/ tests. r=jaws
https://hg.mozilla.org/integration/autoland/rev/bae062fca494
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in browser/. r=jaws,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/b071db6bea7a
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/sync/ r=markh,tcsc
https://hg.mozilla.org/integration/autoland/rev/847445b24636
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in services/fxaccounts/ r=vladikoff
https://hg.mozilla.org/integration/autoland/rev/65104032313d
Replace misnamed `formSubmitURL` and `hostname` properties on nsILoginInfo in mobile/. r=Grisha

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d80312b41cd4
https://hg.mozilla.org/mozilla-central/rev/ea236d72325d
https://hg.mozilla.org/mozilla-central/rev/bae062fca494
https://hg.mozilla.org/mozilla-central/rev/b071db6bea7a
https://hg.mozilla.org/mozilla-central/rev/847445b24636
https://hg.mozilla.org/mozilla-central/rev/65104032313d

Comment 13

[Chris Mills [:cmills]]

Hi Jared, is there any web platform-related documentation to do with regards to this bug?

Comment 14

[Matthew N. [:MattN]]

No, I think he was referring to https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsILoginInfo which I kinda want to delete so people rely on the .idl docs.

Comment 15

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

MattN's correct, I was thinking of the XPCOM IDL docs on MDN.

Comment 16

[Chris Mills [:cmills]]

OK, thanks folks.

No, I think he was referring to https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsILoginInfo which I kinda want to delete so people rely on the .idl docs.

We are aiming to get rid of such docs off MDN, starting around Q4 this year. We'll probably dump the raw HTML for them in a GitHub repo somewhere, so they are accessible if someone desparately needs something out of them.