Closed
Bug 1148230
Opened 9 years ago
Closed 9 years ago
Duplicated size_t(destinationBus->mDuration) >= framesToProcess when computing isCopySafe
Categories
(Core :: Web Audio, defect)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: khuey, Assigned: ehsan.akhgari)
References
Details
http://hg.mozilla.org/mozilla-central/annotate/59554288b4eb/dom/media/webaudio/blink/Reverb.cpp#l192
Flags: needinfo?(ehsan)
Assignee | ||
Comment 1•9 years ago
|
||
This is leftover from bug 815643. In that bug, |destinationChannelL->length()| and |destinationChannelR->length()| both end up being |destinationBus->mDuration| and I forgot to eliminate the common subexpression. <https://github.com/mozilla/gecko-dev/commit/573f70e55#diff-1fd72b36e1fb1e77e797377f6755dbacL180> https://hg.mozilla.org/integration/mozilla-inbound/rev/73d6926f4912
Comment 2•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/73d6926f4912
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•