1148268 - [DeviceStorage] misspelling attribute "mActorDestoryed"

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

trivial bug. simple replace it with "mActorDestroyed".

https://dxr.mozilla.org/mozilla-central/source/dom/devicestorage/DeviceStorageRequestParent.h#310

Comment 1

[Ethan Wu]

Attachment: bug_1148268.patch

Hi, 
Could you please help to review this patch?
thanks.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8584370 [details] [diff] [review]
bug_1148268.patch

Review of attachment 8584370 [details] [diff] [review]:
-----------------------------------------------------------------

You'll also need to update all the code that reference this attribute, otherwise it won't compile, right?

Comment 3

[Ethan Wu]

Attachment: bug_1148268_part2.patch

Hi Shih-Chiang,
Thanks you for your reminder.
this patch will update all the code that reference this attribute.
thanks.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8584414 [details] [diff] [review]
bug_1148268_part2.patch

Review of attachment 8584414 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm! you need to merge these two patch files into one, and follow [1] to provide the checkin comment. Then, r? dhyland because he is the module owner.
Since this is your first patch, please provide the try result as a practice even though it is a trivial patch. :)

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities

Comment 5

[Ethan Wu]

Attachment: bug-1148268-fix_20150330.patch

Hi Shih-Chiang.
Update correct patch and the try result as below [1] link.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=324a02b52a6e

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8585296 [details] [diff] [review]
bug-1148268-fix_20150330.patch

Review of attachment 8585296 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, as I mentioned in comment #4 you should change the reviewer to dhyland. Be sure to modify "r=schien" to "r=dhyland" in your checkin comment.
BTW, you can mark those out-dated patches as "obsolete" (follow the "Details" link in attachments section, then click "edit details").

Comment 7

[Ethan Wu]

Attachment: Bug 1148268 - [DeviceStorage] misspelling attribute "mActorDestoryed"

Comment 8

[Dave Hylands [:dhylands]]

Comment on attachment 8585334 [details] [diff] [review]
Bug 1148268 - [DeviceStorage] misspelling attribute "mActorDestoryed"

Review of attachment 8585334 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks for taking the time to fix this.

Comment 9

[Ethan Wu]

Attachment: Bug 1148268 - [DeviceStorage] misspelling attribute "mActorDestoryed"

Hi,
The result of try is as below [1] link.


[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=2eb6b669abd0

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86578daf0154

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86578daf0154