Closed Bug 1148292 Opened 5 years ago Closed 4 years ago

Refactor MP4Reader / PlatformDecoderModule / MediaDataDecoder to be content agnostic

Categories

(Core :: Audio/Video: Playback, defect, P3)

x86
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file, 4 obsolete files)

The MP4Reader API, should be renamed / refactored so it reflects that it can handle any type of data content.
Remove remnant of libstagefright. This codepath is now unused
Attachment #8587156 - Flags: review?(ajones)
Assignee: nobody → jyavenard
Status: NEW → ASSIGNED
Remove crypto's stagefright dependencies and now-unused code path.
Attachment #8587169 - Flags: review?(edwin)
Use const pointers rather than reference to shared pointers. And fix stagefright constness.
Attachment #8587178 - Flags: review?(ajones)
Comment on attachment 8587156 [details] [diff] [review]
Part1. Remove of now unused code path

Review of attachment 8587156 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8587156 - Flags: review?(ajones) → review+
Attachment #8587178 - Flags: review?(ajones) → review+
Depends on: 1150853
Depends on: 1109433
Attached image Proposed new architecture (obsolete) —
Depends on: 1151378
Comment on attachment 8587156 [details] [diff] [review]
Part1. Remove of now unused code path

moving it to bug 1151378
Attachment #8587156 - Attachment is obsolete: true
Comment on attachment 8587169 [details] [diff] [review]
Part2. Remove libstagefright depencies from Crypto config

moving it to bug 1151378
Attachment #8587169 - Attachment is obsolete: true
Comment on attachment 8587178 [details] [diff] [review]
Part3. Fix constness and remove use of reference to refcounted ptr

moving it to bug 1151378
Attachment #8587178 - Attachment is obsolete: true
Depends on: 1152658
Depends on: 1153049
Depends on: 1154164
Priority: -- → P3
Depends on: 1156708
Attached image Media Stack.png
Rename MediaReader class into MediaFormatDecoder
Attachment #8588514 - Attachment is obsolete: true
Blocks: 1158236
Depends on: 1163458
Component: Audio/Video → Audio/Video: Playback
This task is now done
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.