Closed
Bug 1148323
Opened 10 years ago
Closed 10 years ago
"Show Original Sources" context menu entry never shown as selected
Categories
(DevTools :: Inspector, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
Firefox 40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: fvsch, Assigned: sjakthol)
Details
Attachments
(1 file)
|
2.00 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
In the Rules and Computed panes of the Inspector, the context menu has a "Show Original Sources" option for using source maps.
This option works, but the context menu item is always unchecked, so it's not possible to say if it's on or not (except by looking at the result).
Seen on:
- Firefox 36, Win7, x86
- Firefox 38, Win7, x86_64
|
Assignee | |
Comment 1•10 years ago
|
||
Windows seems to require the menu items to have type="checkbox" before the checked state is shown (cheked="true" seem to be enough on Linux). Tested manually and it seems to work.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a4b9269c6b
Assignee: nobody → sjakthol
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8588291 -
Flags: review?(pbrosset)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8588291 [details] [diff] [review]
bug-1148323-inspector-checkboxes.patch
Review of attachment 8588291 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8588291 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
||
Comment 3•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
|
||
Comment 5•10 years ago
|
||
Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl
Version: Firefox 38 → 38 Branch
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•